Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions CI, fix test builds on main #66

Merged
merged 24 commits into from
Jan 17, 2024

Conversation

grega
Copy link
Member

@grega grega commented Jan 16, 2024

Two issues being resolved here:

  • Test builds have started failing on main (due to Gems being installed that are incompatible with Ruby 2.7.7), see note from Patrick below on resolution
  • Migrating away from Circle CI and on to GitHub Actions (now our preferred CI platform)

Copy link

github-actions bot commented Jan 16, 2024

Test coverage: 100%

@patch0
Copy link
Contributor

patch0 commented Jan 16, 2024

@grega @ce-rpf I've got this testing now with ruby 2.7, 3.1, 3.2, 3.3 and rails 6.1, 7.0, 7.1.

There is a fly in the ointment, which is a lack of default Gemfile. I've updated the README to say that BUNDLE_GEMFILE needs to be exported as an env var, but this is quite a trip hazard compared to regular gems. Using symlinks doesn't work so well, as remote .. in the gemfiles/*.gemfile.lock gets changed to remote . if the Gemfile is symlinked as it was before, leading to test failures (as the Gemfile.lock gets changed).

The other thing is that I've set the .tool-versions ruby version to 2.7.8, which is the lowest version we support. Some of the gems get updated to versions that are not compatible with 2.7 if this is left at 3.x. I guess the next step would be more gemfiles to cover all the combinations of rails and ruby we need coverage for, but it seems fine at the mo with this version set.

@grega grega marked this pull request as ready for review January 17, 2024 11:54
@grega grega changed the title Set up GitHub Action Migrate to GitHub Actions CI, fix test builds on main Jan 17, 2024
@grega grega merged commit 67c03ec into main Jan 17, 2024
10 checks passed
@grega grega deleted the migrate-to-github-actions branch January 17, 2024 12:08
@grega
Copy link
Member Author

grega commented Jan 17, 2024

Note to re-enable Rubocop check is here: #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants