Skip to content

Commit

Permalink
Use LB for kourier again
Browse files Browse the repository at this point in the history
  • Loading branch information
ReToCode committed May 8, 2024
1 parent 42b9e4e commit ad17f06
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
15 changes: 9 additions & 6 deletions openshift/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -133,19 +133,22 @@ function install_serverless(){
export DOCKER_REPO_OVERRIDE=image-registry.openshift-image-registry.svc:5000/openshift-marketplace
OPENSHIFT_CI="true" make generated-files images install-serving || return $?

# Ensure tests trust the OpenShift router CA
trust_router_ca || return $?

popd
}

function install_knative(){
install_serverless || return $?

# To enable gRPC and HTTP2 tests without OCP Route.
# oc patch knativeserving knative-serving \
# -n "${SERVING_NAMESPACE}" \
# --type merge --patch '{"spec": {"ingress": {"kourier": {"service-type": "LoadBalancer"}}}}'
#
# wait_until_service_has_external_ip $SERVING_INGRESS_NAMESPACE kourier || fail_test "Ingress has no external IP"
# wait_until_hostname_resolves "$(kubectl get svc -n $SERVING_INGRESS_NAMESPACE kourier -o jsonpath='{.status.loadBalancer.ingress[0].hostname}')"
oc patch knativeserving knative-serving \
-n "${SERVING_NAMESPACE}" \
--type merge --patch '{"spec": {"ingress": {"kourier": {"service-type": "LoadBalancer"}}}}'

wait_until_service_has_external_ip $SERVING_INGRESS_NAMESPACE kourier || fail_test "Ingress has no external IP"
wait_until_hostname_resolves "$(kubectl get svc -n $SERVING_INGRESS_NAMESPACE kourier -o jsonpath='{.status.loadBalancer.ingress[0].hostname}')"

if [[ ${ENABLE_TLS:-} == "true" ]]; then
configure_cm network system-internal-tls:enabled || fail_test
Expand Down
2 changes: 0 additions & 2 deletions openshift/e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# shellcheck disable=SC1090
source "$(dirname "$0")/e2e-common.sh"

set -x

env

failed=0
Expand Down

0 comments on commit ad17f06

Please sign in to comment.