Refactors of the smart contracts - using error instead of reverts #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… minor modifications
josojo
commented
Jan 4, 2024
|
|
||
| contract ChainIdManager is Owned { | ||
| contract ChainIdManager is Ownable { |
There was a problem hiding this comment.
It feels better to depend on public library
josojo
commented
Jan 4, 2024
| @@ -1,16 +0,0 @@ | |||
| // SPDX-License-Identifier: MIT OR Apache-2.0 | |||
josojo
commented
Jan 4, 2024
| @@ -79,8 +76,7 @@ contract ForkonomicToken is | |||
| /// @dev Allows anyone to prepare the splitting of tokens | |||
| /// by burning them | |||
| /// @param amount The amount of tokens to burn | |||
| function prepareSplittingTokens(uint256 amount) public { | |||
| require(children[0] != address(0), "Children not created yet"); | |||
There was a problem hiding this comment.
replaced with modifier onlyAfterForking
edmundedgar
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and other minor modifications