Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Flatten schema directory tree #1655

Merged
merged 29 commits into from
Oct 31, 2023
Merged

refactor: Flatten schema directory tree #1655

merged 29 commits into from
Oct 31, 2023

Conversation

ashkarpetin
Copy link
Contributor

@ashkarpetin ashkarpetin commented Oct 30, 2023 •
edited
Loading

Summary

Aso renamed schemas:

  • PercentageFormula to PercentageFeeFormula
  • PaymentToken to PaymentInstructionToken
  • PaymentMethods to PaymentInstructionMethods
  • manual to ManualTax
  • rebilly-taxjar to RebillyTaxJarTax
  • rebilly-avalara to RebillyAvalaraTax

Links

Checklist

  • Writing style
  • API design standards

@ashkarpetin ashkarpetin self-assigned this Oct 30, 2023
@ashkarpetin ashkarpetin mentioned this pull request Oct 30, 2023
Closed
13 tasks
@ashkarpetin ashkarpetin changed the title refactor: Simplify schema directory tree refactor: Flatten schema directory tree Oct 30, 2023
@ashkarpetin ashkarpetin marked this pull request as ready for review October 30, 2023 19:27
@ashkarpetin ashkarpetin requested review from a team as code owners October 30, 2023 19:27
@justnero
Copy link
Contributor

Please merge after Rebilly/rebilly-php#652, so we could get a cleaner diff PR in PHP SDK

@ashkarpetin ashkarpetin merged commit 4c65e2b into main Oct 31, 2023
@ashkarpetin ashkarpetin deleted the simplify-schema-directory-tree branch October 31, 2023 10:48
This was referenced Oct 31, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvc9109 jvc9109 jvc9109 approved these changes

@justnero justnero justnero approved these changes

@lexerom lexerom lexerom approved these changes

Assignees

@ashkarpetin ashkarpetin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashkarpetin @justnero @lexerom @jvc9109