Skip to content

Commit

Permalink
fix(dialog): add href to CTA host's in all demos
Browse files Browse the repository at this point in the history
  • Loading branch information
adamjohnson committed Dec 13, 2024
1 parent 2eb2add commit fb242b0
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 14 deletions.
4 changes: 1 addition & 3 deletions elements/rh-dialog/demo/color-context.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ <h2 slot="header">Color Context</h2>
<p>Duis mollis, est non commodo luctus, nisi erat porttitor ligula, eget lacinia odio sem nec elit. Donec sed
odio dui. Maecenas faucibus mollis interdum. Fusce dapibus, tellus ac cursus commodo, tortor mauris
condimentum nibh, ut fermentum massa justo sit amet risus.</p>
<rh-cta slot="footer">
<a href="#bar">Learn more</a>
</rh-cta>
<rh-cta slot="footer" href="#bar">Call to Action</rh-cta>
</rh-dialog>
<rh-button id="context-trigger">Open Dialog</rh-button>
</rh-context-demo>
Expand Down
4 changes: 1 addition & 3 deletions elements/rh-dialog/demo/events.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ <h2 slot="header">Modal dialog with a header</h2>
aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu
fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit
anim id est laborum.</p>
<rh-cta>
<a href="#bar">Learn more</a>
</rh-cta>
<rh-cta slot="footer" href="#bar">Call to Action</rh-cta>
</rh-dialog>
<rh-button id="trigger">Open</rh-button>
<fieldset>
Expand Down
4 changes: 1 addition & 3 deletions elements/rh-dialog/demo/lots-of-content.html
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@ <h2 slot="header">Modal with a header with a truly excessive super duper long ti
<p>Duis mollis, est non commodo luctus, nisi erat porttitor ligula, eget lacinia odio sem nec elit. Donec sed
odio dui. Maecenas faucibus mollis interdum. Fusce dapibus, tellus ac cursus commodo, tortor mauris
condimentum nibh, ut fermentum massa justo sit amet risus.</p>
<rh-cta slot="footer">
<a href="#bar">Learn more</a>
</rh-cta>
<rh-cta slot="footer" href="#bar">Call to Action</rh-cta>
</rh-dialog>

<script type="module">
Expand Down
4 changes: 1 addition & 3 deletions elements/rh-dialog/demo/no-header-content.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ <h2>This dialog has no slotted header content</h2>
consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est
laborum.</p>
<rh-cta id="test-dark-child">
<a href="#">Call-to-action</a>
</rh-cta>
<rh-cta slot="footer" href="#bar">Call to Action</rh-cta>
</rh-dialog>

<script type="module">
Expand Down
2 changes: 1 addition & 1 deletion elements/rh-dialog/demo/no-headings.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
attribute are provided, the dialog's accessible name defaults to the text content of its trigger element.
Learn more about these attributes in the <a href="https://ux.redhat.com/elements/dialog/code/">rh-dialog docs</a>.
</p>
<rh-cta slot="footer" href="#">Call-to-action</rh-cta>
<rh-cta slot="footer" href="#">Call to Action</rh-cta>
</rh-dialog>

<script type="module">
Expand Down
2 changes: 1 addition & 1 deletion elements/rh-dialog/demo/rh-dialog.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ <h2 slot="header">Modal dialog with a header</h2>
aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu
fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit
anim id est laborum.</p>
<rh-cta slot="footer" href="#bar">Learn more</rh-cta>
<rh-cta slot="footer" href="#bar">Call to Action</rh-cta>
</rh-dialog>

<script type="module">
Expand Down

0 comments on commit fb242b0

Please sign in to comment.