-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute --restart-request option #154
Conversation
20db922
to
41e4618
Compare
I am not sure about the |
55e6f57
to
b0a9f0c
Compare
Yeah, I am also not sure about RE. On one hand I like it, on the other hand I feel like it is not necessary. To me the idea of REQ re-execution is to be able to re-execute isolated REQs and since you can already use the option multiple times I don't really see much need for allowing RE (also, it feels like it would be easier to list the REQs explicitly rather than coming up with the right RE to match most of them). I appreciate the idea of distinguishing RE by
while the following variant is more readable and requires no RE implementation in this PR:
Following the KISS principle I would slightly prefer "dumb" version without RE but I don't really mind it. I briefly tested it and it works fine. I think this is a really important addition that will be used a lot! |
b0a9f0c
to
fcc6139
Compare
OK, I have removed the regexp support. Btw, note the recently added short version |
fcc6139
to
a2d0872
Compare
@The-Mule Would you mind reviewing&testing it one more time? Thank you. |
testing feedback provided in #151 (comment) |
No description provided.