Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial command and class skeleton #6

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Initial command and class skeleton #6

merged 5 commits into from
Feb 16, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Feb 13, 2024

No description provided.

lukaszachy
lukaszachy reviewed Feb 13, 2024
View reviewed changes
newa/__init__.py Outdated Show resolved Hide resolved
@happz happz marked this pull request as ready for review February 15, 2024 12:32
@kkaarreell
Copy link
Collaborator

I think the event processor should be using different filename prefix for input (containing [event]) and produced files (containing also [errata]).

kkaarreell
kkaarreell approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@kkaarreell kkaarreell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version LGTM. Thank you.

@kkaarreell
Copy link
Collaborator

kkaarreell commented Feb 16, 2024 •
edited
Loading

I think the event processor should be using different filename prefix for input (containing [event]) and produced files (containing also [errata]).

This has been addressed by introducinginit- prefix for input files.

@thrix thrix requested review from lukaszachy and thrix and removed request for lukaszachy February 16, 2024 12:21
thrix
thrix approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrix thrix merged commit 244bb1d into main Feb 16, 2024
1 check passed
@thrix thrix deleted the command-skeleton branch February 16, 2024 12:22
kkaarreell pushed a commit that referenced this pull request Mar 1, 2024
@happz @kkaarreell
Initial command and class skeleton (#6)
3fc4b4e 
* Initial command and class skeleton

* squash: make YAML safe

* sqush: move things around to create true container

* squash: switch erratum to one release only

* squash: undo single erratum
The-Mule pushed a commit to The-Mule/newa that referenced this pull request Apr 29, 2024
@happz @The-Mule
Initial command and class skeleton (RedHatQE#6)
77ab0c3 
* Initial command and class skeleton

* squash: make YAML safe

* sqush: move things around to create true container

* squash: switch erratum to one release only

* squash: undo single erratum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy left review comments

@kkaarreell kkaarreell kkaarreell approved these changes

@thrix thrix thrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @kkaarreell @thrix @lukaszachy