Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace parent with parent_id in Jira config file #9

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

kkaarreell
Copy link
Collaborator

@kkaarreell kkaarreell commented Mar 1, 2024

Replacing parent attribute with parent_id making its purpose more obvious.

@kkaarreell kkaarreell requested a review from happz March 1, 2024 09:52
@happz
Copy link
Collaborator

happz commented Mar 1, 2024

@kkaarreell the order was incorrect on purpose, to test whether the primitive loop-based resolving in the initial patch would be able to handle actions whose dependency has not been defined yet: https://github.com/RedHatQE/newa/blob/main/newa/cli.py#L149 :)

Plus, code deserves an update too, https://github.com/RedHatQE/newa/blob/main/newa/__init__.py#L212, https://github.com/RedHatQE/newa/blob/main/newa/cli.py#L149, https://github.com/RedHatQE/newa/blob/main/newa/cli.py#L160

@kkaarreell
Copy link
Collaborator Author

@kkaarreell the order was incorrect on purpose, to test whether the primitive loop-based resolving in the initial patch would be able to handle actions whose dependency has not been defined yet: https://github.com/RedHatQE/newa/blob/main/newa/cli.py#L149 :)

OK, I will restore it then.

Plus, code deserves an update too, https://github.com/RedHatQE/newa/blob/main/newa/__init__.py#L212, https://github.com/RedHatQE/newa/blob/main/newa/cli.py#L149, https://github.com/RedHatQE/newa/blob/main/newa/cli.py#L160

Interesting, I did grep -R parent but overlooked it. Fixing now.

@kkaarreell
Copy link
Collaborator Author

You know what.. screw this. I am actually not convinced now that replacing parent with parent_id is an improvement. :-D

@kkaarreell kkaarreell force-pushed the ks_parent_id branch 2 times, most recently from 7537d48 to 9cc1515 Compare March 1, 2024 10:52
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@happz happz merged commit 163813b into main Mar 15, 2024
1 check passed
@happz happz deleted the ks_parent_id branch March 15, 2024 13:21
The-Mule pushed a commit to The-Mule/newa that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants