Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix GetUserWantToPlayList, GetGameRankAndScore, GetLeaderboardEntries, and README #63

Merged

Conversation

joshraphael
Copy link
Contributor

@joshraphael joshraphael commented Nov 19, 2024

I noticed the ID field on the GetUserWantToPlayList is marked as GameID, but the actual response only has ID. Also I don't think we need the z parameter anymore, but maybe you can tell me if i'm wrong

Edit: I'm also seeing a mismatching in the GetGameRankAndScore query parameters. I removed the z parameter and change the i to a g in accordance with what the request expects based on the php code

Added missing Leaderboards endpoints to the readme

Screenshot from 2024-11-18 22-59-14

GetLeaderboardEntries response gives back the +00:00 timezone instead of Z

Screenshot from 2024-11-22 07-13-48

@joshraphael joshraphael changed the title docs: fix GetUserWantToPlayList response and query parameters docs: fix GetUserWantToPlayList, GetGameRankAndScore, README Nov 22, 2024
@joshraphael joshraphael changed the title docs: fix GetUserWantToPlayList, GetGameRankAndScore, README docs: fix GetUserWantToPlayList, GetGameRankAndScore, GetLeaderboardEntries, and README Nov 22, 2024
Copy link
Member

@wescopeland wescopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wescopeland wescopeland merged commit baab54b into RetroAchievements:main Nov 22, 2024
2 checks passed
@joshraphael joshraphael deleted the fix/get-user-want-to-play-list branch November 23, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants