Fixed bank borrow bug #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeghen
commented
Dec 17, 2021
| @@ -268,7 +244,6 @@ contract Bank is BankStorage, AccessControlEnumerable, Initializable { | |||
| reserve.collateralizationRatio) * 100; | |||
| maxBorrow *= debt.priceGranularity; | |||
| maxBorrow /= collateral.priceGranularity; | |||
| maxBorrow -= vaults[msg.sender].debtAmount; | |||
There was a problem hiding this comment.
This was the source of the error, subtracting the debt amount was not needed. This was missed since there was no test for the scenario that causes this to be a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occured when you borrow, then try to borrow more. There was 1 line removed from
vaultBorrow. A test for this scenario was added tobank.js