Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
DivadNojnarg committed May 5, 2022
1 parent dc64466 commit 46cadc3
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 29 deletions.
1 change: 0 additions & 1 deletion .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ jobs:
with:
extra-packages: |
rcmdcheck
echarts4r
- uses: r-lib/actions/check-r-package@v1

Expand Down
3 changes: 1 addition & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ Authors@R: c(
person("David", "Granjon", email = "[email protected]", role = c("aut", "cre")),
person(family = "RinteRface", role = "cph"),
person(family = "Almasaeed Studio", role = c("ctb", "cph"), comment = "AdminLTE3 theme for Bootstrap 4"),
person("Winston", "Chang", role = c("ctb", "cph"), comment = "Utils functions from shinydashboard"),
person("Thomas", "Park", role = c("ctb", "cph"), comment = "Bootswatch Sketchy theme CSS"))
person("Winston", "Chang", role = c("ctb", "cph"), comment = "Utils functions from shinydashboard"))
Maintainer: David Granjon <[email protected]>
Description: Make 'Bootstrap 4' Shiny dashboards. Use the full power
of 'AdminLTE3', a dashboard template built on top of 'Bootstrap 4'
Expand Down
2 changes: 0 additions & 2 deletions R/bs4DashGallery.R
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
#'
#' }
bs4DashGallery <- function() { # nocov start
if (!requireNamespace(package = "echarts4r"))
message("Package 'echarts4r' is required to run this function")
if (!requireNamespace(package = "thematic"))
message("Package 'thematic' is required to run this function")
if (!requireNamespace(package = "waiter"))
Expand Down
24 changes: 0 additions & 24 deletions inst/examples/showcase/app.R
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ library(shiny)
library(bs4Dash)
library(thematic)
library(waiter)
library(magrittr)

thematic_shiny()

Expand Down Expand Up @@ -1264,29 +1263,6 @@ shinyApp(
hist(rnorm(input$obs))
})

# this is not reactive but just for fixing the plot size on the client side.
output$riverPlot <- renderEcharts4r({
river %>%
e_charts(dates) %>%
e_river(apples) %>%
e_river(bananas) %>%
e_river(pears) %>%
e_tooltip(trigger = "axis") %>%
e_title("River charts", "(Streamgraphs)") %>%
e_theme("shine")
})

output$rosetype <- renderEcharts4r({
plot <- mtcars %>%
head() %>%
dplyr::mutate(model = row.names(.)) %>%
e_charts(model) %>%
e_pie(hp, roseType = "radius")
if (input$dark_mode) plot <- plot %>% e_theme(echarts_dark_theme$name)
plot
})


observeEvent(input$current_tab, {
if (input$current_tab == "cards") {
showModal(modalDialog(
Expand Down

0 comments on commit 46cadc3

Please sign in to comment.