move away from shiny:::processDeps and prefer htmltools::renderTags

RinteRface · Jul 22, 2021 · b2ca46c · b2ca46c
1 parent 60ddf46
commit b2ca46c
Show file tree

Hide file tree

Showing 16 changed files with 20 additions and 16 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -4,7 +4,8 @@ Patch to fix CRAN warning on Mac M1.
 
 ## Minor changes
 
-
+- Move away from `shiny:::processDeps` in favor of `htmltools::renderTags`. Does not
+impact end user. 
 
 # bs4Dash 2.0.1
 

diff --git a/R/useful-items.R b/R/useful-items.R
@@ -2316,7 +2316,7 @@ userMessage <- function(..., author = NULL, date = NULL,
 #'            inputId = "reload",
 #'            label = "Click me!", 
 #'            icon = icon("sync"), 
-#'            dashboardBadge(1, color = "orange")
+#'            dashboardBadge(1, color = "primary")
 #'           )
 #'          )
 #'         )
@@ -2338,7 +2338,7 @@ updateUserMessages <- function(id, action = c("add", "remove", "update"),
     if (inherits(c, "shiny.tag") || inherits(c, "shiny.tag.list")) {
       # necessary if the user pass input/output with deps
       # that are not yet available in the page before inserting the new tag
-      c <- processDeps(c, session)
+      c <- htmltools::renderTags(c)
     }
     c
   })

diff --git a/docs/articles/bs4Dash.html b/docs/articles/bs4Dash.html
diff --git a/docs/articles/css-preloader.html b/docs/articles/css-preloader.html
diff --git a/docs/articles/extra-elements.html b/docs/articles/extra-elements.html
diff --git a/docs/articles/improved-boxes.html b/docs/articles/improved-boxes.html
diff --git a/docs/articles/index.html b/docs/articles/index.html
diff --git a/docs/articles/more-skins.html b/docs/articles/more-skins.html
diff --git a/docs/news/index.html b/docs/news/index.html
diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml
@@ -9,5 +9,5 @@ articles:
   index: index.html
   more-skins: more-skins.html
   step-by-step: step-by-step.html
-last_built: 2021-07-22T11:03Z
+last_built: 2021-07-22T13:53Z
 
diff --git a/docs/reference/userMessage.html b/docs/reference/userMessage.html
diff --git a/inst/bs4Dash-2.0.2/bs4Dash.js b/inst/bs4Dash-2.0.2/bs4Dash.js
@@ -1977,7 +1977,7 @@ Shiny.addCustomMessageHandler("user-messages", function(message) {
     if (content.text.html === undefined) {
       text = content.text;
     } else {
-      text = Shiny.renderHtml(content.text.html, $([]), content.text.deps).html;
+      text = Shiny.renderHtml(content.text.html, $([]), content.text.dependencies).html;
     } 
   }
 

diff --git a/inst/bs4Dash-2.0.2/bs4Dash.min.js b/inst/bs4Dash-2.0.2/bs4Dash.min.js
diff --git a/inst/bs4Dash-2.0.2/bs4Dash.min.js.map b/inst/bs4Dash-2.0.2/bs4Dash.min.js.map
diff --git a/man/userMessage.Rd b/man/userMessage.Rd
diff --git a/srcjs/bs4Dash-2.0.2/userMessages.js b/srcjs/bs4Dash-2.0.2/userMessages.js
@@ -10,7 +10,7 @@ Shiny.addCustomMessageHandler("user-messages", function(message) {
     if (content.text.html === undefined) {
       text = content.text;
     } else {
-      text = Shiny.renderHtml(content.text.html, $([]), content.text.deps).html;
+      text = Shiny.renderHtml(content.text.html, $([]), content.text.dependencies).html;
     } 
   }