Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANDFIRE symbology files for QGIS and Web #781

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ChloeSeeborg
Copy link
Collaborator

Added new LANDFIRE symbology files for QGIS and Web that previously didn't exist.

@ChloeSeeborg ChloeSeeborg added the symbology Use for new symbology work label Dec 23, 2024
@jtgilbert
Copy link
Contributor

@ChloeSeeborg I'm not sure exactly why, but one or more of the web files isn't passing validation.

@ChloeSeeborg
Copy link
Collaborator Author

@jtgilbert Is it because they are not in the usual format? They are .txt files because the web raster symbology is set up differently than the vector web symbology .json files.

@jtgilbert
Copy link
Contributor

@ChloeSeeborg It looks like the existing landfire rasters have FOUR numerical values for each category (R, G, B, and opacity I think), where these new ones only have the three.

@jtgilbert
Copy link
Contributor

@MattReimer any idea why this check is failing?

@MattReimer
Copy link
Member

The python errors have been fixed. The remaining problems are all pretty legitimate:

=========================== short test summary info ============================
FAILED python/test.py::TestLambdaFunc::test_validateRamp - AssertionError: 8 != 0 : Errors were found: 


[./Symbology/web/Shared/Historic_Disturbance.txt] :: Error parsing QGIS Color Ramp: list index out of range

[./Symbology/web/Shared/Vegetation_Departure.txt] :: Error parsing QGIS Color Ramp: list index out of range

[./Symbology/web/Shared/Veg_Cover.txt] :: Error parsing QGIS Color Ramp: list index out of range

[./Symbology/web/Shared/Fuel_Disturbance.txt] :: Error parsing QGIS Color Ramp: list index out of range

[./Symbology/web/Shared/Succession_Classes.txt] :: Error parsing QGIS Color Ramp: list index out of range

[./Symbology/web/Shared/Veg_Height.txt] :: Error parsing QGIS Color Ramp: list index out of range

[./Symbology/web/Shared/Vegetation_Condition.txt] :: Error parsing QGIS Color Ramp: list index out of range

[./Symbology/web/Shared/fccs.txt] :: Error parsing QGIS Color Ramp: list index out of range
========================= 1 failed, 3 passed in 0.[80](https://github.com/Riverscapes/RiverscapesXML/actions/runs/12692291077/job/35377283605?pr=781#step:6:81)s ==========================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
symbology Use for new symbology work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants