Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roaring64: fix TestSetAndGetBigTimestamp (non-UTC) #465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starius
Copy link
Contributor

@starius starius commented Jan 10, 2025

The test was broken if local timezone it not UTC. For example, in timezone UTC-03:00 it failed with this error:

--- FAIL: TestSetAndGetBigTimestamp (0.00s)
    bsi64_test.go:111:
      Error Trace:    bsi64_test.go:111
      Error:          Not equal:
         expected: "3024-10-23T16:55:46.763295273Z"
         actual  : "3024-10-23T13:55:46.763295273-03:00"

The test was broken if local timezone it not UTC. For example, in timezone
UTC-03:00 it failed with this error:

--- FAIL: TestSetAndGetBigTimestamp (0.00s)
    bsi64_test.go:111:
      Error Trace:    bsi64_test.go:111
      Error:          Not equal:
         expected: "3024-10-23T16:55:46.763295273Z"
         actual  : "3024-10-23T13:55:46.763295273-03:00"
@lemire
Copy link
Member

lemire commented Jan 10, 2025

Let us run tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants