This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Split magnetometer node into C++ class and header #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhannay567
suggested changes
Jan 6, 2021
There was a problem hiding this comment.
This looks good, just a small variable name error. Also, change the name of the files to be all lowercase, so it should be magnetometer.cpp, etc.
Also, be sure to test and see if the code compiles before making a PR, just to make sure you didn't miss any obvious errors, as well as running make format to fix any code format problems.
| std::string sub_topic = pnh.param("mag_sub_topic", std::string("/magnetometer/vector")); | ||
| std::string pub_topic = pnh.param("mag_pub_topic", std::string("/magnetometer_mag")); | ||
| g_mag_field_covar = pnh.param("mag_field_variance", 1e-6); | ||
| g_mag_field_pub = nh.advertise<sensor_msgs::MagneticField>(pub_topic, 10); |
There was a problem hiding this comment.
Here you are still using the g_ prefix, while the member variable does not have it. Remove the g_ prefix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite the igvc_gazebo/magnetometer node to be a C++ class
This PR does the following:
Fixes #740
Testing steps (If relevant)
Test Case 1
Test Case 2
Expectation: Retain functionality of the node
Self Checklist
make format