Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Drake suggested 1.37.0 #377

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

IanTheEngineer
Copy link
Member

@IanTheEngineer IanTheEngineer commented Jan 24, 2025

Toward #373 and #376.


This change is Reviewable

@jwnimmer-tri
Copy link
Contributor

BTW I think the local.bzl error is because Drake now requires Bazel >= 7.4.1 as our minimum.

All of the ~5 lines in that say USE_BAZEL_VERSION=7.1.2 should upgrade to either 7.4.1 or 8.0.1.

Copy link
Member Author

@IanTheEngineer IanTheEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks Jeremy. I hadn't realized this particular failure was tied to the Bazel version. I set it to 8.0.1 to be as up-to-date as possible by default.

Reviewable status: 0 of 12 files reviewed, all discussions resolved

Copy link
Member Author

@IanTheEngineer IanTheEngineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have been too hasty to embrace 8.0. It looks like other dependencies will need to be update to make that happen. I rolled it back to 7.4.1 for now.

Reviewable status: 0 of 12 files reviewed, all discussions resolved

Copy link
Contributor

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. The CI errors now look like the normal baseline level of failures, nothing newly failing.

:lgtm:

Reviewed 5 of 12 files at r1, 7 of 7 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IanTheEngineer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants