[workspace] Bump pybind11 fork to latest commit (merge w/ upstream v2.11.1) #20362
Conversation
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", missing label for release notes (waiting on @EricCousineau-TRI)
a discussion (no related file):
Working: Failures due to bad implicit conversion (I think)
//bindings/pydrake/common:py/type_safe_index_pybind_test
a discussion (no related file):
Working: Failures due to something going awry with rvalue casting, e.g.
$ bazel test //bindings/pydrake/multibody:py/plant_test
...
RuntimeError: Unable to cast Python <class 'plant_test.AppliedForceTestSystem_𝓣AutoDiffXd𝓤'> instance to C++ rvalue: instance has multiple references (#define PYBIND11_DETAILED_ERROR_MESSAGES or compile in debug mode for details)
...
This comment was marked as resolved.
This comment was marked as resolved.
EricCousineau-TRI
force-pushed
the
feature-drake-pybind-pr64
branch
2 times, most recently
from
33a73ff to
ce159ac
Compare
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", missing label for release notes (waiting on @EricCousineau-TRI)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: Failures due to bad implicit conversion (I think)
//bindings/pydrake/common:py/type_safe_index_pybind_test
Done.
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: Failures due to something going awry with rvalue casting, e.g.
$ bazel test //bindings/pydrake/multibody:py/plant_test ... RuntimeError: Unable to cast Python <class 'plant_test.AppliedForceTestSystem_𝓣AutoDiffXd𝓤'> instance to C++ rvalue: instance has multiple references (#define PYBIND11_DETAILED_ERROR_MESSAGES or compile in debug mode for details) ...
Done.
a discussion (no related file):
Working: Requires testing for Anzu.
There was a problem hiding this comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", missing label for release notes (waiting on @EricCousineau-TRI)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: Requires testing for Anzu.
Done. See Anzu PR 10993.
EricCousineau-TRI
force-pushed
the
feature-drake-pybind-pr64
branch
from
ce159ac to
4b82525
Compare
There was a problem hiding this comment.
+@jwnimmer-tri and +@rpoyner-tri for review, please
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),rpoyner-tri(platform), missing label for release notes (waiting on @EricCousineau-TRI)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignees rpoyner-tri(platform),jwnimmer-tri(platform), missing label for release notes (waiting on @EricCousineau-TRI)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Done. See Anzu PR 10993.
Update PR once more to doubly confirm.
There was a problem hiding this comment.
Reviewable status: LGTM missing from assignees rpoyner-tri(platform),jwnimmer-tri(platform), missing label for release notes (waiting on @EricCousineau-TRI)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Update PR once more to doubly confirm.
Done. Same PR - Anzu 10993
EricCousineau-TRI
added
the
release notes: fix
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 7 of 7 files at r3, all commit messages.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee rpoyner-tri(platform)
a discussion (no related file):
Working
To be cautious, we should fire off a wheel build before landing this (macOS Arm Wheel is the best choice). I can do that after pushes / review are finished.
tools/workspace/pybind11/repository.bzl line 10 at r3 (raw file):
# https://github.com/RobotLocomotion/pybind11/blob/drake/include/pybind11/detail/common.h # and if it has changed, then update the version number in the two # pybind11-*.cmake files in the current directory to match.
We're at 2.11.1 now in the RLG/pybind11 fork, so this cmake stuff mentioned in the comment here needs to bump up.
EricCousineau-TRI
force-pushed
the
feature-drake-pybind-pr64
branch
from
4b82525 to
14da014
Compare
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee rpoyner-tri(platform)
tools/workspace/pybind11/repository.bzl line 10 at r3 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
We're at
2.11.1now in the RLG/pybind11 fork, so this cmake stuff mentioned in the comment here needs to bump up.
Done.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform)
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
@drake-jenkins-bot mac-arm-monterey-unprovisioned-clang-wheel-experimental-release please |
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee rpoyner-tri(platform)
a discussion (no related file):
Working: I also have an updated PR to try and make the pybind11 fork CI pass:
RobotLocomotion/pybind11#67
Once CI passes there, I will request (rubber stamp) review then merge it.
For us, functionally, it may not affect things, but may good to use pin with all CI green.
WDYT?
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee rpoyner-tri(platform)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: I also have an updated PR to try and make the pybind11 fork CI pass:
RobotLocomotion/pybind11#67Once CI passes there, I will request (rubber stamp) review then merge it.
For us, functionally, it may not affect things, but may good to use pin with all CI green.WDYT?
Let's discuss at RobotLocomotion/pybind11#67. If that PR merges, then we'll need to bump Drake to use it.
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 7 of 7 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: 2 unresolved discussions
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
@drake-jenkins-bot mac-arm-monterey-unprovisioned-clang-wheel-experimental-release please
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion
a discussion (no related file):
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
pending tests
OK wheel smoke build passed.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Let's discuss at RobotLocomotion/pybind11#67. If that PR merges, then we'll need to bump Drake to use it.
If you'd like to merge this PR as-is, and then re-bump again later, that's also OK by me.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
If you'd like to merge this PR as-is, and then re-bump again later, that's also OK by me.
Done. Will avoid the churn for now.
a discussion (no related file):
Sorry, one more: RobotLocomotion/pybind11#66
This is a small bugfix only really relevant to the fork pybind11 CI.
I'd like to merge it, though, just to keep things somewhat aligned.
It should also not affect testing that has already been done (beyond nominal PR testing)
EricCousineau-TRI
force-pushed
the
feature-drake-pybind-pr64
branch
from
14da014 to
64bb3d7
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),jwnimmer-tri(platform)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Sorry, one more: RobotLocomotion/pybind11#66
This is a small bugfix only really relevant to the fork pybind11 CI.
I'd like to merge it, though, just to keep things somewhat aligned.It should also not affect testing that has already been done (beyond nominal PR testing)
Done.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion
tools/workspace/pybind11/repository.bzl line 11 at r5 (raw file):
# and if it has changed, then update the version number in the two # pybind11-*.cmake files in the current directory to match.
Working: Oops, extra newline.
This merges in pybind11 upstream's v2.11.1 Removes need for monostate_pybind.h Changes error types for certain tests
EricCousineau-TRI
force-pushed
the
feature-drake-pybind-pr64
branch
from
64bb3d7 to
977574d
Compare
There was a problem hiding this comment.
Reviewable status:
tools/workspace/pybind11/repository.bzl line 11 at r5 (raw file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: Oops, extra newline.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status:
Requires RobotLocomotion/pybind11#64
This change is