Skip to content

Commit

Permalink
Core/Unit: Fix DualWield Off-hand hit penalty (TrinityCore#30444)
Browse files Browse the repository at this point in the history
* Offhand attacks that occur while on-next-hit abilities such as Heroic Strike are queued do not suffer the dual wield to-hit penalty.
  • Loading branch information
CraftedRO authored Nov 20, 2024
1 parent a93b115 commit c6fb439
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/server/game/Entities/Unit/Unit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12128,8 +12128,8 @@ float Unit::MeleeSpellMissChance(Unit const* victim, WeaponAttackType attType, i
//calculate miss chance
float missChance = victim->GetUnitMissChance();

// melee attacks while dual wielding have +19% chance to miss
if (!spellId && haveOffhandWeapon())
// Check if dual wielding, add additional miss penalty - when mainhand has on next swing spell, offhand doesnt suffer penalty
if (!spellId && haveOffhandWeapon() && attType != RANGED_ATTACK && !m_currentSpells[CURRENT_MELEE_SPELL])
missChance += 19.0f;

// bonus from skills is 0.04%
Expand Down

0 comments on commit c6fb439

Please sign in to comment.