-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added description to prepareExtractionCoordinates_ function, need review #2
base: develop
Are you sure you want to change the base?
Conversation
// chrom_list contains list of pointers for empty chromatograms. coordinates is also an empty vector of coordinates for each chromatogram. | ||
// transition_exp_used contains peptide name, protein name. Is transition_exp_used one transition or many? | ||
// trafo_inverse has mapping from iRT to seconds. cp has further params for extracting chromatogram. | ||
// For example, function will fill one coordinate as : 400 Th, 785 Th, (1800 + 300)s, (1800 -300)s, id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go into the header
I suggest to actually annotate functions in the header since this then also shows up in the documentation, also we already have some documentation there so you may want to merely enhance it: OpenMS/src/openms/include/OpenMS/ANALYSIS/OPENSWATH/OpenSwathWorkflow.h Lines 316 to 337 in c648c46
|
@@ -908,8 +913,8 @@ namespace OpenMS | |||
// Then correct the start/end positions and add the extra_rt_extract parameter | |||
prepare_coordinates_sub(chrom_list, coordinates, transition_exp_used, 0.0, ms1); | |||
for (std::vector< ChromatogramExtractor::ExtractionCoordinates >::iterator it = coordinates.begin(); it != coordinates.end(); ++it) | |||
{ | |||
it->rt_start = trafo_inverse.apply(it->rt_start) - (cp.rt_extraction_window + cp.extra_rt_extract)/ 2.0; | |||
{// iterator it parse through complete vector of coordinates and all transitions have RT end/start set to +/-300 seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably we dont want to write explicit numbers in here as 300 seconds is just an example value, not a fixed value
Co-authored-by: Arraxx <[email protected]>
* read swath window file with no header In response to OpenMS#6055 allow openSwath to be able to read window files with no header. * fix lint * Revert "fix lint" This reverts commit 83875b6. * Apply suggestions from code review * change std::cout to OPENMS_LOG_INFO * In header check, check for "e" float nums previous check would not detect examples like 4e2 as a valid swath window (and would put this as a header instead). Allow "e" characters to be supported. Also revert back to std::cout because OPENMS_LOG_INFO does not seem to be working. * minor style edits * replace std:cerr and std::cout with OPENMS LOG when use std::endl instead of \n the OPENMS LOG statements work * accept tab deliminators allow for headers separated by tab deliminators to also be accepted Co-authored-by: GitHub Linter <[email protected]> Co-authored-by: Timo Sachsenberg <[email protected]>
[FIX] Add new DBsearchDeconvMass util to list of executables to be built (and documented)
I added some description to the prepareExtractionCoordinates_ function. I am not sure about the transition_exp_used size.