Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/mrmpeakpicking none smoother #111

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Conversation

singjc
Copy link
Collaborator

@singjc singjc commented Jan 30, 2024

Description

When MRMPeakPicking is selected in the GUI and the default smoothing parameters is set to 'none', peak picking fails because it has to be one of 'original', 'sgolay', or 'gauss'.

Added case if 'none' set the MRMPeakPicking smoothing to 'original'

I also added smoothing dict constant to use full smoothing names in UI.

Fixes #110

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested via GUI and ran unittests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Contents (#111)

Other

  • add smoothing dict to constants
  • [BUG] when smoothing is set to none for MRMPeakPicker
  • gaussian -> gauss
  • MRMPeakPicking none -> original
  • remove unused constant
  • remove old constant import

@singjc singjc linked an issue Jan 30, 2024 that may be closed by this pull request
@singjc singjc requested a review from irahorecka January 30, 2024 22:49
@singjc singjc added the bug Something isn't working label Jan 30, 2024
@singjc singjc merged commit ad0c55f into dev Jan 30, 2024
10 checks passed
@singjc singjc deleted the bug/mrmpeakpicking_none_smoother branch January 30, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MRMTransitionGroupPicker does not work with "none"
3 participants