[CHANGE] ui option name for feature file boundaries #99
Conversation
There was a problem hiding this comment.
Changes are good. However currently there is an issue in the raw peak GUI display failing to find features. Should try to address this in this PR as well because it concerns these. Unsure if we should use the plotChromatogram method I added to the loaders or decouple this feature reading from the peak picking server a bit because it is not doing peak picking just reading results and thus needs different arguments from the other peak pickers (e.g. transitionGroupFeatures).
massdash/server/PeakPickingServer.py
Outdated
| @@ -35,7 +35,7 @@ def __init__(self, peak_picking_settings: PeakPickingUISettings, chrom_plot_sett | |||
|
|
|||
| def perform_osw_pyprophet_peak_picking(self, xic_data: SqMassLoader, transition_list_ui: Literal['ExtractedIonChromatogramAnalysisUI', 'RawTargetedExtractionAnalysisUI']): | |||
There was a problem hiding this comment.
I am having difficulties with this method in the GUI could you please look into this? I think that the loader object for the raw data is not currently being passed which causes loadTransitionGroupFeature to fail. Not sure what the best way to solve this without just adding more arguments
There was a problem hiding this comment.
You're getting this error?
AttributeError: 'NoneType' object has no attribute 'loadTransitionGroupFeature'
There was a problem hiding this comment.
yes thats the error. I think it is because there is no XIC data/loader object passed
There was a problem hiding this comment.
I passed the mzml loader object now instead to get the feature data from the results file. I think I initially used the sqMass workflow that's why it failed.
Feature file peak boundary rendering doesn't work for the raw GUI workflow. Added the mzml loader object to 1Dplotting to get feature file boundaries.
…me_results_peak_boundaries
Change peak picking option OSW-PyProphet to Feature File Boundaries
Contents (#99)
Other
Uncategorised!