Skip to content

Commit

Permalink
Move deployment folder out of the way (#1313)
Browse files Browse the repository at this point in the history
- Also move img assets
- Shorten kyma readme
  • Loading branch information
chgeo authored Dec 4, 2024
1 parent f4f96b5 commit 86f336a
Show file tree
Hide file tree
Showing 10 changed files with 8 additions and 8 deletions.
File renamed without changes
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -e
cd "$(dirname "$(npm root)")"
DIR="$(pwd)"
DIR="$(pwd)/.github"

npm install --no-save yaml

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
8 changes: 4 additions & 4 deletions README-Kyma-Runtime.md → README-Kyma.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ cds add html5-repo
Create a secret `container-registry` with credentials to access the container registry:
```
bash deployment/kyma/scripts/create-container-registry-secret.sh
bash .github/deployment/kyma/scripts/create-container-registry-secret.sh
```
The *Docker Server* is the full-qualified hostname of your container registry.
Expand All @@ -67,7 +67,7 @@ The *Docker Server* is the full-qualified hostname of your container registry.
This step is only required if you're using a BTP Trial account. If you're using a production or a free tier account then you can create HDI Container from Kyma directly by adding a [mapping to your Kyma namespace in your HANA Cloud Instance](https://blogs.sap.com/2022/12/15/consuming-sap-hana-cloud-from-the-kyma-environment/) and skip this step.
```
bash deployment/kyma/scripts/create-db-secret.sh sflight-db
bash .github/deployment/kyma/scripts/create-db-secret.sh sflight-db
```
It will create a HDI container `sflight-db` instance on your currently targeted Cloud Foundry space and creates a secret `sflight-db` with the credentials in your current Kubernetes namespace.
Expand Down Expand Up @@ -112,7 +112,7 @@ html5-apps-deployer:
```

4. Add backend destinations required by HTML5 Apps Deployer.

```diff
- backendDestinations: {}
+ backendDestinations:
Expand Down Expand Up @@ -199,7 +199,7 @@ pack build $YOUR_CONTAINER_REGISTRY/sflight-srv \
## Build HTML5 application deployer image

```
bash deployment/kyma/scripts/build-ui-image.sh
bash .github/deployment/kyma/scripts/build-ui-image.sh
```

## Push docker images
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ The purpose of this sample app is to:
* Demonstrate and compare SAP Fiori features on various stacks (CAP Node.js, CAP Java SDK, ABAP)
* Run UI test suites on various stacks

![Process Travels Page](img.png)
![Process Travels Page](.github/assets/img.png)

The app still contains some workarounds that are going to be addressed over time.
In some cases, the model and the handlers can be improved or simplified once further planned CAP features become available.
In other cases, the app itself could be improved. For example, calculation of the total price for a travel
currently simply sums up the single prices ignoring the currencies.

> For enabling all features of the Analytical List Page (ALP) in the Node.js runtime, we have switched on the new OData parser
> For enabling all features of the Analytical List Page (ALP) in the Node.js runtime, we have switched on the new OData parser
(`odata_new_parser: true` in `package.json`), which is still in an **experimental state**.
Early adopters may use this feature in own projects on their own risk.
You can also use the ALP with the standard OData parser, but then some features like grouping in the table are not available.
Expand Down Expand Up @@ -141,7 +141,7 @@ that HDI container are stored locally on your filesystem (default-env.json).

## Deployment to SAP Business Technology Platform - Kyma Runtime

The deployment to Kyma Runtime is explained in file [README-Kyma-Runtime.md](./README-Kyma-Runtime.md).
The deployment to Kyma Runtime is explained in file [README-Kyma.md](./README-Kyma.md).

## Creating an SAP Fiori App from Scratch

Expand Down

0 comments on commit 86f336a

Please sign in to comment.