CAP Java: Maintaining seats #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmikhailenko
approved these changes
Jan 14, 2025
srv/src/main/java/com/sap/cap/sflight/processor/UpdateFlightSeatsHandler.java
Outdated
Show resolved
Hide resolved
This is actually not needed for the use case at hand. Also removed
|
Hi @rjayasinghe - thanks for this! |
rjayasinghe
added a commit
that referenced
this pull request
Jan 25, 2025
Fixes #1358 This test depends on the fact that the state of the data is initial. Disables the test in question when application is tested against HANA container. We could also refresh the container or upload the data there again, but I do not think that this particular test is important there. Not perfect, though. E.g. test will fail if one uses `default-env.json`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation by colleague Irena.