Improvement suggestions (#395)

The PR contains some improvement suggestions. 1. Adds the missing dev-dependency to @sap/cds-dk in the db module. This fixes a problem that causes the build command to fail with `could not determine executable to run` 2. Adds more details about the route mapping to the README --------- Co-authored-by: Markus Ofterdinger <[email protected]>
SAP-samples · Nov 25, 2024 · 3f97ef2 · 3f97ef2
1 parent 49ed638
commit 3f97ef2
Show file tree

Hide file tree

Showing 3 changed files with 2,656 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -238,6 +238,8 @@ Deploy as Multitenant Application:
 - Run `cf deploy mta_archives/bookshop-mt_1.0.0.mtar`
 - Go to another subaccount in your global account, under subscriptions and subscribe to the application you deployed.
 - Run `cf map-route bookshop-mt-app <YOUR DOMAIN> --hostname <SUBSCRIBER TENANT>-<ORG>-<SPACE>-bookshop-mt-app` or create and bind the route manually.
+  - `<YOUR DOMAIN>`: Find the app domain for your landscape by executing `cf domains`. It commonly starts with `cfapps.`.
+  - `<SUBSCRIBER TENANT>`: The subdomain of the subscriber subaccount. You can find this info in the subaccount overview.
 
 > [!NOTE]
 > Please note that the route length is limited to 63 characters and can easily be exceeded. So keeping the app name and sub-account subdomain as short as possible will help you stay within length.