Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typed service POJOs in tests and custom handler #267

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Use typed service POJOs in tests and custom handler #267

merged 7 commits into from
Nov 14, 2023

Conversation

mofterdinger
Copy link
Member

No description provided.

@mofterdinger mofterdinger marked this pull request as draft November 14, 2023 11:29
@mofterdinger mofterdinger changed the title Used typed service POJOs in tests Use typed service POJOs in tests and custom handler Nov 14, 2023
beckermarc
beckermarc reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@beckermarc beckermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in AdminServiceAddressITestBase there is also a service that could be replaced.

srv/src/main/java/my/bookshop/handlers/CatalogServiceHandler.java Outdated Show resolved Hide resolved
srv/src/main/java/my/bookshop/handlers/AdminServiceAddressHandler.java Outdated Show resolved Hide resolved
@mofterdinger
Copy link
Member Author

AdminServiceAddressITestBase

thanks, done.

@mofterdinger mofterdinger marked this pull request as ready for review November 14, 2023 13:13
@mofterdinger mofterdinger merged commit 8be1a33 into main Nov 14, 2023
@mofterdinger mofterdinger deleted the demo_service_pojos branch November 14, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckermarc beckermarc beckermarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofterdinger @beckermarc