Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore CodeList aspect #420

Closed
wants to merge 1 commit into from
Closed

Restore CodeList aspect #420

wants to merge 1 commit into from

Conversation

etimr
Copy link
Contributor

@etimr etimr commented Dec 19, 2024

No description provided.

@etimr etimr requested review from agoerler and beckermarc December 19, 2024 11:46
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Dec 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Dec 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@beckermarc
Copy link
Contributor

Can we combine all changes in #419?
Is @cds.odata.valuelist: false actually required? Did you run into issues without it?

etimr
etimr commented Dec 19, 2024
View reviewed changes
srv/admin-service.cds
@@ -21,6 +21,7 @@ service AdminService @(requires: 'admin') {
entity Authors as projection on my.Authors;
entity Orders as select from my.Orders;
extend my.Genres with Hierarchy;
@cds.odata.valuelist: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also works without this annotation now, should I still leave it there to show that we don't use a standard ValueList provided by CodeList or should I remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is not required to be disabled I don't think we need to remove it. Then changes in #419 would be sufficient.

@etimr etimr mentioned this pull request Dec 19, 2024
Merged
@beckermarc beckermarc closed this Dec 19, 2024
@beckermarc beckermarc deleted the tree-table-restore-codelist branch December 19, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoerler agoerler Awaiting requested review from agoerler

@beckermarc beckermarc Awaiting requested review from beckermarc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etimr @beckermarc @OlenaTi