feat: Add Metering Header (#104)

SAP · Sep 4, 2024 · b780212 · b780212
1 parent 78d78d2
commit b780212
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 22 deletions.
diff --git a/packages/core/src/http-client.test.ts b/packages/core/src/http-client.test.ts
@@ -1,7 +1,7 @@
 import nock from 'nock';
 import {
   mockClientCredentialsGrantCall,
-  mockInference
+  aiCoreDestination
 } from '../../../test-util/mock-http.js';
 import { executeRequest } from './http-client.js';
 
@@ -16,26 +16,20 @@ describe('http-client', () => {
     const mockPrompt = { prompt: 'some test prompt' };
     const mockPromptResponse = { completion: 'some test completion' };
 
-    const scope = mockInference(
-      {
-        data: {
-          deploymentConfiguration: { deploymentId: 'deployment_id' },
-          prompt: 'some test prompt'
-        }
-      },
-      {
-        data: mockPromptResponse,
-        status: 200
+    const scope = nock(aiCoreDestination.url, {
+      reqheaders: {
+        'ai-resource-group': 'default',
+        'ai-client-type': 'AI SDK JavaScript'
       }
-    );
+    })
+      .post('/v2/some/endpoint', mockPrompt)
+      .query({ 'api-version': 'mock-api-version' })
+      .reply(200, mockPromptResponse);
+
     const res = await executeRequest(
-      { url: 'mock-endpoint', apiVersion: 'mock-api-version' },
-      {
-        deploymentConfiguration: { deploymentId: 'deployment_id' },
-        ...mockPrompt
-      }
+      { url: '/some/endpoint', apiVersion: 'mock-api-version' },
+      mockPrompt
     );
-
     expect(scope.isDone()).toBe(true);
     expect(res.status).toBe(200);
     expect(res.data).toEqual(mockPromptResponse);

diff --git a/packages/core/src/http-client.ts b/packages/core/src/http-client.ts
@@ -95,7 +95,8 @@ function mergeWithDefaultRequestConfig(
     method: 'post',
     headers: {
       'content-type': 'application/json',
-      'ai-resource-group': 'default'
+      'ai-resource-group': 'default',
+      'ai-client-type': 'AI SDK JavaScript'
     },
     params: apiVersion ? { 'api-version': apiVersion } : {}
   };

diff --git a/test-util/mock-http.ts b/test-util/mock-http.ts
@@ -4,8 +4,6 @@ import { fileURLToPath } from 'url';
 import { DestinationAuthToken, HttpDestination, ServiceCredentials } from '@sap-cloud-sdk/connectivity';
 import nock from 'nock';
 import {
-  BaseLlmParameters,
-  CustomRequestConfig,
   EndpointOptions } from '@sap-ai-sdk/core';
 import { dummyToken } from './mock-jwt.js';
 
@@ -91,7 +89,6 @@ export function mockClientCredentialsGrantCall(
 export function mockInference(
   request: {
     data: any;
-    requestConfig?: CustomRequestConfig;
   },
   response: {
     data: any;