Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reuse check-public-api script from Cloud SDK GH action #254

Merged
merged 17 commits into from
Nov 25, 2024

Conversation

shibeshduw
Copy link
Contributor

@shibeshduw shibeshduw commented Oct 30, 2024

Context

AI/gen-ai-hub-sdk-js-backlog#115.

Definition of Done

  • [ ] Code is tested (Unit, E2E)
  • [ ] Error handling created / updated & covered by the tests above
  • [ ] Documentation updated
  • [ ] (Optional) Aligned changes with the Java SDK
  • [ ] (Optional) Release notes updated

@shibeshduw shibeshduw marked this pull request as ready for review November 14, 2024 13:11
@shibeshduw shibeshduw requested a review from deekshas8 November 15, 2024 10:24
@deekshas8 deekshas8 enabled auto-merge (squash) November 21, 2024 15:07
.github/workflows/build.yml Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 25, 2024 11:20

Pull request was closed

@ZhongpinWang ZhongpinWang reopened this Nov 25, 2024
@ZhongpinWang ZhongpinWang merged commit 8eb322e into main Nov 25, 2024
16 checks passed
@ZhongpinWang ZhongpinWang deleted the public-api-check-gh-action branch November 25, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants