Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update service binding docs #279

Merged
merged 4 commits into from
Nov 11, 2024
Merged

chore: Update service binding docs #279

merged 4 commits into from
Nov 11, 2024

Conversation

deekshas8
Copy link
Contributor

@deekshas8 deekshas8 commented Nov 8, 2024

Context

AI/gen-ai-hub-sdk-js-backlog#157.

Update README to include a note about AI SDK handling of ai core service binding

Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

packages/foundation-models/README.md Outdated Show resolved Hide resolved
packages/foundation-models/README.md Outdated Show resolved Hide resolved
@@ -48,7 +48,11 @@ To ensure compatibility and manage updates effectively, we strongly recommend us
## Prerequisites

- [Enable the AI Core service in SAP BTP](https://help.sap.com/docs/sap-ai-core/sap-ai-core-service-guide/initial-setup).
- Project configured with Node.js v20 or higher and native ESM support enabled.
- Configure the project with **Node.js v20 or higher** and **native ESM** support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see many copy/pasted content for different packages :)

Copy link
Contributor

@jjtang1985 jjtang1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.
Please consider adding the doc for the Launchpad scenario.

@deekshas8 deekshas8 requested a review from jjtang1985 November 11, 2024 07:15
@deekshas8 deekshas8 merged commit df1dc07 into main Nov 11, 2024
10 checks passed
@deekshas8 deekshas8 deleted the update-readmes branch November 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants