Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update available model list from GenAI Hub. #439

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

shibeshduw
Copy link
Contributor

Context

SAP/ai-sdk-js-backlog#203.

What this PR does and why it is needed

This PR updates the list of models available and are shown in auto completion while using Orchestration Client.

Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if aleph alpha models should be included.

Comment on lines 47 to 48
export type AiCoreAlephAlphaChatModel = LiteralUnion<
'alephalpha-pharia-1-7b-control' | 'alephalpha-pharia-1-66b-control'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] I cannot find these two models on SAP notes but only in orchestration service. Are you sure these models are already publicly announced to be supported? Otherwise, I would leave them out first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you're right. They are only internally supported at the moment.

Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shibeshduw shibeshduw merged commit b7f7f75 into main Jan 10, 2025
10 checks passed
@shibeshduw shibeshduw deleted the update-model-list branch January 10, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants