chore: Add sample code for base64 encoded image in Orchestration #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
reviewed
Jan 21, 2025
sample-code/src/orchestration.ts
Outdated
| @@ -354,10 +356,14 @@ export async function orchestrationChatCompletionImage(): Promise<OrchestrationR | |||
| } | |||
| }); | |||
|
|
|||
| const imageFilePath = join(__dirname, 'src', 'media', 'sample-image.png'); | |||
| const mimeType = lookup(extname(imageFilePath).toLowerCase()); | |||
There was a problem hiding this comment.
[pp] Computing the mime type is maybe a bit overkill, since we anyway hardcode png here in the filename. Thus might Asseln hard code the mime type ;)
There was a problem hiding this comment.
I agree that hardcoding the mime type here is probably enough, but please keep it separate from the template string, so our users still know which part to replace, in case their image is of a different type.
jjtang1985
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes SAP/ai-sdk-js-backlog#213.
What this PR does and why it is needed