Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to Orchestration v0.48.2 #468

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

MatKuhr
Copy link
Member

@MatKuhr MatKuhr commented Jan 17, 2025

Context

Closes SAP/ai-sdk-js-backlog#208.

@MatKuhr MatKuhr changed the title feat: [DevOps] Update to Orchestration v0.48.2 feat: Update to Orchestration v0.48.2 Jan 17, 2025
@jjtang1985
Copy link
Contributor

jjtang1985 commented Jan 17, 2025

Normally, I guess we can merge the spec update PRs like this, as we should have good test coverage for avoiding non-breaking changes.
However, @tomfrenken mentioned the failing e2e yesterday.
I would wait for his fix first, then merge this PR for simplifying Tom's job.

@tomfrenken
Copy link
Member

IMO we can merge it, orchestration types are not affecting the langchain fix, since the current langchain client only relies on the azure types.

@tomfrenken
Copy link
Member

Only the release is blocked until langchain is fixed.

@tomfrenken tomfrenken marked this pull request as ready for review January 17, 2025 12:56
Copy link
Member

@tomfrenken tomfrenken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomfrenken tomfrenken merged commit 0a62553 into main Jan 17, 2025
11 checks passed
@tomfrenken tomfrenken deleted the spec-update/orchestration/v0.48.2 branch January 17, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants