feat: Orchestration with Prompt Registry #514
Merged
+82
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
changed the title
deekshas8
reviewed
Jan 31, 2025
packages/orchestration/README.md
Outdated
| > #### Harmonized API | ||
| > | ||
| > As the orchestration service API is harmonized, you can switch to a different model, even from another vendor, by changing only the `model_name` property. | ||
| > Here’s an example where only one line of code is changed. |
There was a problem hiding this comment.
[pp] I feel like we dont need this. The above sentence say only one change is needed and we highlight that in the code
There was a problem hiding this comment.
Agreed. After reviewing this I felt that we can rather just link to the docs of orchestration where this is explained better anyway, so I shortened this to just a short explanation + link
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes SAP/ai-sdk-js-backlog#219.
What this PR does and why it is needed