Skip to content

Commit

Permalink
fix(styles): pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
@mikerodonnell89
mikerodonnell89 committed Nov 7, 2023
1 parent 6b61444 commit 3182b5b
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 24 deletions.
4 changes: 0 additions & 4 deletions packages/styles/src/card.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -390,10 +390,6 @@ $fd-card-header-outline-offset: 0.0625rem !default;
@include fd-reset();

padding-bottom: 0.5rem;

h3 {
font-size: var(--sapFontSize);
}
}

&__content-group {
Expand Down
20 changes: 10 additions & 10 deletions packages/styles/stories/Components/card/object-card.example.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,23 @@
<div class="fd-card__content" role="group" aria-label="Card Content">
<div class="fd-card__content-container">
<div class="fd-card__content-section">
<div class="fd-card__content-title-container"><h3>Group Title 1</h3></div>
<div class="fd-card__content-title-container">Group Title 1</div>
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
</div>
Expand All @@ -44,13 +44,13 @@
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
<div class="fd-card__content-group">
Expand Down Expand Up @@ -98,13 +98,13 @@ <h3 style="margin: 0;">Group Title 1</h3>
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
</div>
Expand All @@ -123,13 +123,13 @@ <h3 style="margin: 0;">Group Title 2</h3>
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
<div class="fd-card__content-group">
<div class="fd-card__content-group-text">
<span>Label:</span>
<span class="fd-link">Text</span>
<span>Text</span>
</div>
</div>
</div>
Expand Down
20 changes: 10 additions & 10 deletions packages/styles/tests/__snapshots__/styles.test.ts.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11231,23 +11231,23 @@ exports[`Check stories > Components/Card > Story ObjectCard > Should match snaps
<div class=\\"fd-card__content\\" role=\\"group\\" aria-label=\\"Card Content\\">
<div class=\\"fd-card__content-container\\">
<div class=\\"fd-card__content-section\\">
<div class=\\"fd-card__content-title-container\\"><h3>Group Title 1</h3></div>
<div class=\\"fd-card__content-title-container\\">Group Title 1</div>
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
</div>
Expand All @@ -11256,13 +11256,13 @@ exports[`Check stories > Components/Card > Story ObjectCard > Should match snaps
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
<div class=\\"fd-card__content-group\\">
Expand Down Expand Up @@ -11310,13 +11310,13 @@ exports[`Check stories > Components/Card > Story ObjectCard > Should match snaps
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
</div>
Expand All @@ -11335,13 +11335,13 @@ exports[`Check stories > Components/Card > Story ObjectCard > Should match snaps
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
<div class=\\"fd-card__content-group\\">
<div class=\\"fd-card__content-group-text\\">
<span>Label:</span>
<span class=\\"fd-link\\">Text</span>
<span>Text</span>
</div>
</div>
</div>
Expand Down

0 comments on commit 3182b5b

Please sign in to comment.