Review feedback von @ChristophHi

feature-libs/quote/components/header/overview/quote-header-overview.component.html

@@ -21,7 +21,7 @@ <h3 class="cx-status">
           [charactersLimit]="getCharactersLimitForCardTile()"
         ></cx-card>
         <button
-          *ngIf="isQuoteInformationEditable(quoteDetails)"
+          *ngIf="isQuoteEditableForBuyer(quoteDetails)"
           class="link cx-action-link cx-edit-btn"
           (click)="toggleEditMode()"
         >
@@ -40,8 +40,10 @@ <h3 class="cx-status">
     <div class="cx-summary-card">
       <cx-card
         [content]="
-          getEstimatedAndDate(quoteDetails, quoteDetails.creationTime | cxDate)
-            | async
+          getEstimatedTotalAndDate(
+            quoteDetails,
+            quoteDetails.creationTime | cxDate
+          ) | async
         "
       ></cx-card>
     </div>

feature-libs/quote/components/header/overview/quote-header-overview.component.spec.ts

@@ -313,22 +313,22 @@ describe('QuoteHeaderOverviewComponent', () => {
 
     it('should return "false" if the quote information is not editable', () => {
       quote.isEditable = false;
-      expect(component.isQuoteInformationEditable(quote)).toBe(false);
+      expect(component.isQuoteEditableForBuyer(quote)).toBe(false);
     });
 
     it('should return "false" if the quote information is not editable for "SELLER_DRAFT"', () => {
       quote.state = QuoteState.SELLER_DRAFT;
-      expect(component.isQuoteInformationEditable(quote)).toBe(false);
+      expect(component.isQuoteEditableForBuyer(quote)).toBe(false);
     });
 
     it('should return "true" if the quote information is editable for "BUYER_DRAFT"', () => {
       quote.state = QuoteState.BUYER_DRAFT;
-      expect(component.isQuoteInformationEditable(quote)).toBe(true);
+      expect(component.isQuoteEditableForBuyer(quote)).toBe(true);
     });
 
     it('should return "true" if the quote information is editable for "BUYER_OFFER"', () => {
       quote.state = QuoteState.BUYER_OFFER;
-      expect(component.isQuoteInformationEditable(quote)).toBe(true);
+      expect(component.isQuoteEditableForBuyer(quote)).toBe(true);
     });
   });
 
@@ -421,7 +421,7 @@ describe('QuoteHeaderOverviewComponent', () => {
       };
 
       component
-        .getEstimatedAndDate(mockQuote, undefined)
+        .getEstimatedTotalAndDate(mockQuote, undefined)
         .subscribe((result) => {
           expect(result).toEqual(expected);
         });

feature-libs/quote/components/header/overview/quote-header-overview.component.ts

@@ -33,9 +33,9 @@ export class QuoteHeaderOverviewComponent {
   protected translationService = inject(TranslationService);
   protected quoteUIConfig = inject(QuoteUIConfig);
 
-  private static NO_DATA = '-';
-  private static CHARACTERS_LIMIT = 255;
-  private static DEFAULT_CARD_TILE_MAX_CHARS = 100;
+  protected static NO_DATA = '-';
+  protected static CHARACTERS_LIMIT = 255;
+  protected static DEFAULT_CARD_TILE_MAX_CHARS = 100;
 
   quoteDetails$: Observable<Quote> = this.quoteFacade.getQuoteDetails();
   iconTypes = ICON_TYPE;
@@ -61,7 +61,7 @@ export class QuoteHeaderOverviewComponent {
    * @param {Quote} quote - quote
    * @returns {boolean} - if the quote is editable and its state is 'QuoteState.BUYER_DRAFT' or 'QuoteState.BUYER_OFFER', otherwise returns 'false'.
    */
-  isQuoteInformationEditable(quote: Quote): boolean {
+  isQuoteEditableForBuyer(quote: Quote): boolean {
     return (
       quote.isEditable &&
       (quote.state === QuoteState.BUYER_DRAFT ||
@@ -152,7 +152,7 @@ export class QuoteHeaderOverviewComponent {
    * @param {any} createdDate - Created date
    * @returns {Observable<Card>} - Card content
    */
-  getEstimatedAndDate(
+  getEstimatedTotalAndDate(
     quote: Quote,
     createdDate?: string | null
   ): Observable<Card> {

feature-libs/quote/components/list/quote-list.component.ts

@@ -15,11 +15,11 @@ import { QuoteListComponentService } from './quote-list-component.service';
   changeDetection: ChangeDetectionStrategy.OnPush,
 })
 export class QuoteListComponent {
-  protected quoteListService = inject(QuoteListComponentService);
+  protected quoteListComponentService = inject(QuoteListComponentService);
 
-  sorts = this.quoteListService.sorts;
-  sortLabels$ = this.quoteListService.sortLabels$;
-  quotesState$ = this.quoteListService.quotesState$;
+  sorts = this.quoteListComponentService.sorts;
+  sortLabels$ = this.quoteListComponentService.sortLabels$;
+  quotesState$ = this.quoteListComponentService.quotesState$;
   dateFormat: string = 'MMMM d, YYYY h:mm aa';
   iconTypes = ICON_TYPE;
 
@@ -29,11 +29,11 @@ export class QuoteListComponent {
   }
 
   changeSortCode(sortCode: string): void {
-    this.quoteListService.setSort(sortCode);
+    this.quoteListComponentService.setSort(sortCode);
   }
 
   changePage(page: number): void {
-    this.quoteListService.setCurrentPage(page);
+    this.quoteListComponentService.setCurrentPage(page);
   }
 
   /**

feature-libs/quote/core/connectors/quote.connector.ts

@@ -20,56 +20,56 @@ import { QuoteAdapter } from './quote.adapter';
 
 @Injectable()
 export class QuoteConnector {
-  protected adapter = inject(QuoteAdapter);
+  protected quoteAdapter = inject(QuoteAdapter);
 
   public getQuotes(
     userId: string,
     pagination: PaginationModel
   ): Observable<QuoteList> {
-    return this.adapter.getQuotes(userId, pagination);
+    return this.quoteAdapter.getQuotes(userId, pagination);
   }
 
   public createQuote(
     userId: string,
     quoteStarter: QuoteStarter
   ): Observable<Quote> {
-    return this.adapter.createQuote(userId, quoteStarter);
+    return this.quoteAdapter.createQuote(userId, quoteStarter);
   }
 
   public getQuote(userId: string, quoteCode: string): Observable<Quote> {
-    return this.adapter.getQuote(userId, quoteCode);
+    return this.quoteAdapter.getQuote(userId, quoteCode);
   }
 
   public editQuote(
     userId: string,
     quoteCode: string,
     quoteMetadata: QuoteMetadata
   ): Observable<unknown> {
-    return this.adapter.editQuote(userId, quoteCode, quoteMetadata);
+    return this.quoteAdapter.editQuote(userId, quoteCode, quoteMetadata);
   }
 
   public performQuoteAction(
     userId: string,
     quoteCode: string,
     quoteAction: QuoteActionType
   ): Observable<unknown> {
-    return this.adapter.performQuoteAction(userId, quoteCode, quoteAction);
+    return this.quoteAdapter.performQuoteAction(userId, quoteCode, quoteAction);
   }
 
   public addComment(
     userId: string,
     quoteCode: string,
     quoteComment: Comment
   ): Observable<unknown> {
-    return this.adapter.addComment(userId, quoteCode, quoteComment);
+    return this.quoteAdapter.addComment(userId, quoteCode, quoteComment);
   }
 
   public addDiscount(
     userId: string,
     quoteCode: string,
     discount: QuoteDiscount
   ): Observable<unknown> {
-    return this.adapter.addDiscount(userId, quoteCode, discount);
+    return this.quoteAdapter.addDiscount(userId, quoteCode, discount);
   }
 
   public addQuoteEntryComment(
@@ -78,7 +78,7 @@ export class QuoteConnector {
     entryNumber: string,
     comment: Comment
   ): Observable<unknown> {
-    return this.adapter.addQuoteEntryComment(
+    return this.quoteAdapter.addQuoteEntryComment(
       userId,
       quoteCode,
       entryNumber,

feature-libs/quote/core/facade/quote.service.ts

@@ -69,7 +69,7 @@ export class QuoteService implements QuoteFacade {
   protected commandService = inject(CommandService);
   protected activeCartFacade = inject(ActiveCartFacade);
   protected routingService = inject(RoutingService);
-  protected multiCartService = inject(MultiCartFacade);
+  protected multiCartFacade = inject(MultiCartFacade);
   protected quoteCartService = inject(QuoteCartService);
   protected cartUtilsService = inject(CartUtilsService);
   protected globalMessageService = inject(GlobalMessageService);
@@ -106,7 +106,7 @@ export class QuoteService implements QuoteFacade {
           )
         ),
         tap(([_, userId, quote]) => {
-          this.multiCartService.loadCart({
+          this.multiCartFacade.loadCart({
             userId,
             cartId: quote.cartId as string,
             extraData: {
@@ -307,7 +307,7 @@ export class QuoteService implements QuoteFacade {
     quoteId: string,
     actionType: QuoteActionType
   ) {
-    this.multiCartService.loadCart({
+    this.multiCartFacade.loadCart({
       userId: userId,
       cartId: cartId,
       extraData: {