chore: CXSPA-4724 Upgrade to Angular 16 #17941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CXSPA-3073
CXSPA-3074
CXSPA-3075
CXSPA-3076
Manual upgrades: - Nx upgraded to 16.10.0 - @ng-select/ng-select upgraded to 11.1.1 - @ngx-infinite-scroll upgraded to 16.0.0 - @angular-eslint/schematics upgraded to 16.2.0
- an output of 'nx migrate --run-migrations'
- fixed type errors after TypeScript upgrade - remove 'entryComponents' from modules - handle new type of 'routerEvent' property from Scroll class https://github.com/angular/angular/blob/b9a4941a327954c5c6b06a995de8f959ee0d63f6/packages/router/src/events.ts#L586 https://github.com/angular/angular/blob/229331e11b6c214f74c9801aa52eb9cd47d7fc76/CHANGELOG.md?plain=1#L732
- removed usage of 'defaultProject' property - it has been removed in v16 - addressed changes in SchematicTestRunner API https://github.com/angular/angular-cli/blob/b5a8174a75f6fd700f2e468563744bdb022a51fc/CHANGELOG.md?plain=1#L631 https://github.com/angular/angular-cli/blob/b5a8174a75f6fd700f2e468563744bdb022a51fc/CHANGELOG.md?plain=1#L1141
- updating dependencies in libraries 'npm run config:update --bump-versions' - linting
- setting `clearContext: true` to all karma config files to avoid `Some of your tests did a full page reload!` error - fixing issues caused by changes in Router API - `events: Observable<RouterEvent>` -> `events: Observable<Event>` - fixing issues with `jest.spyOn` when used on properties that are not configurable - caused by `zone.js` update (see: angular/angular#50756) - fixing `Error: NG04002: Cannot match any routes.` that causes infinite loop of running tests - `waitForAsync` causing issues in `unit-level-order-overview.component.spec.ts` - fix async test in quick-order.service.spec.ts causing errors thrown in `afterAll` - TS issue - `observable.toPromise()` -> `firstValueFrom(observable)` in `schematics` library - TS issue - `[] as unknown[]` in `use-default-provide-config.ts` - updating schematics snapshot - remove `globalSetup: 'jest-preset-angular/global-setup'` to avoid `ngcc` warning
pawelfras
force-pushed
the
feature/CXSPA-4724-angular-16-upgrade
branch
from
6b000e3 to
7a9b513
Compare
- added "@angular-eslint/recommended" plugin to .eslintrc.json - added to project eslint rules that are no logner part of @angular-eslint. See: angular-eslint/angular-eslint#1353 (comment) - all errors related to "@nx/enforce-module-boundaries" marked as warnings (core, storefrontlib + some individual files) - all errors related to "@angular-eslint/no-empty-lifecycle-method" marked as warnings
- validate-lint.sh: '@nrwl/cli' has been removed - use 'nx' instead
pawelfras
force-pushed
the
feature/CXSPA-4724-angular-16-upgrade
branch
from
4c3d642 to
eb27fd6
Compare
- main.server.ts: "renderModuleFactory" as heeb removed from "@angular/platform-server" - use "renderModule" instead
pawelfras
changed the base branch from
epic/pf-rxjs-7-before-6.6
to
epic/CXSPA-2897
- remove 'BrowserModule.withServerTransition' from storefrontapp and schematics' snapshot
- remove 'BrowserModule.withServerTransition' from storefrontapp and schematics' snapshot
- Angular upgraded to 16.2.10 - NX upgraded to 17.0.0
|
Test PR is no longer needed. The update to Angular 16 has been addressed in a different PR: #18022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR FOR TESTING PURPOSES - DO NOT MERGE
This PR contains all actions related to upgrading Spartacus to Angular 16. The branch has been cut from the epic branch with an upgrade to RxJS 7.
DETAILED Description - TBD