Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow inline styling propagation from CMS #17988

Merged
merged 9 commits into from
Oct 19, 2023
Merged

fix: Allow inline styling propagation from CMS #17988

merged 9 commits into from
Oct 19, 2023

Conversation

rmch91
Copy link
Contributor

@rmch91 rmch91 commented Oct 18, 2023

@rmch91 rmch91 requested a review from a team as a code owner October 18, 2023 09:56
@github-actions github-actions bot marked this pull request as draft October 18, 2023 09:56
@rmch91 rmch91 marked this pull request as ready for review October 18, 2023 10:01
@cypress
Copy link

cypress bot commented Oct 18, 2023 •
edited
Loading

5 flaky tests on run #41684 ↗︎

0 119 2 0 Flakiness 5

Details:

Merge 098153c into 376f1b7...
Project: spartacus Commit: 45b25ad2c1 ℹ️
Status: Passed Duration: 07:53 💡
Started: Oct 19, 2023 12:14 PM Ended: Oct 19, 2023 12:22 PM
Flakiness  regression/asm/asm.deeplink.core-e2e.cy.ts • 2 flaky tests • B2C

View Output Video

Test Artifacts
Assisted Service Module > Customer Support Agent - Emulation&deeplink > should emulate customer and navigate to support ticket with deeplink after agent login (CXSPA-3263) Test Replay Output Screenshots Video
Assisted Service Module > Customer Support Agent - Emulation&deeplink > should emulate customer and navigate to saved cart with deeplink after agent login (CXSPA-3263) Test Replay Output Screenshots Video
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Output Screenshots Video
SSR > should render PLP Test Replay Output Screenshots Video
SSR > should render PDP Test Replay Output Screenshots Video

Review all test suite changes for PR #17988 ↗︎

@github-actions github-actions bot marked this pull request as draft October 18, 2023 14:06
@rmch91 rmch91 marked this pull request as ready for review October 19, 2023 09:20
@github-actions github-actions bot marked this pull request as draft October 19, 2023 09:40
@rmch91 rmch91 marked this pull request as ready for review October 19, 2023 10:09
@github-actions github-actions bot marked this pull request as draft October 19, 2023 11:28
@rmch91 rmch91 marked this pull request as ready for review October 19, 2023 12:00
@rmch91 rmch91 merged commit 40515ff into develop-6.6.x Oct 19, 2023
22 checks passed
@rmch91 rmch91 deleted the feature/CXSPA-3708 branch October 19, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matejk00 Matejk00 Matejk00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmch91 @Matejk00