Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add terms and conditions message alert #17990

Merged
merged 2 commits into from
Oct 23, 2023
Merged

feat: add terms and conditions message alert #17990

merged 2 commits into from
Oct 23, 2023

Conversation

Matejk00
Copy link
Contributor

Closes: CXSPA-3171

@Matejk00 Matejk00 requested a review from a team as a code owner October 19, 2023 10:30
@github-actions github-actions bot marked this pull request as draft October 19, 2023 10:31
@Matejk00 Matejk00 marked this pull request as ready for review October 19, 2023 11:53
@github-actions github-actions bot marked this pull request as draft October 19, 2023 12:16
@cypress
Copy link

cypress bot commented Oct 19, 2023 •
edited
Loading

3 flaky tests on run #41703 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge 360ad25 into 8914181...
Project: spartacus Commit: 8a68da9c8d ℹ️
Status: Passed Duration: 07:11 💡
Started: Oct 23, 2023 9:42 AM Ended: Oct 23, 2023 9:49 AM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Output Screenshots Video
SSR > should render PLP Test Replay Output Screenshots Video
SSR > should render PDP Test Replay Output Screenshots Video

Review all test suite changes for PR #17990 ↗︎

@Matejk00 Matejk00 marked this pull request as ready for review October 19, 2023 12:50
FollowTheFlo
FollowTheFlo approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@FollowTheFlo FollowTheFlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me

@github-actions github-actions bot marked this pull request as draft October 23, 2023 08:46
@Matejk00 Matejk00 marked this pull request as ready for review October 23, 2023 09:27
@Matejk00 Matejk00 merged commit aa9f1db into epic/opf Oct 23, 2023
@Matejk00 Matejk00 deleted the feature/CXSPA-3171 branch October 23, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FollowTheFlo FollowTheFlo FollowTheFlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matejk00 @FollowTheFlo