Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: SSR E2E Testing Framework #18779

Merged
merged 18 commits into from
May 16, 2024
Merged

test: SSR E2E Testing Framework #18779

merged 18 commits into from
May 16, 2024

Conversation

Zeyber
Copy link
Contributor

@Zeyber Zeyber commented Apr 30, 2024

Closes: CXSPA-6525

@Zeyber Zeyber requested a review from a team as a code owner April 30, 2024 10:08
@github-actions github-actions bot marked this pull request as draft April 30, 2024 10:08
@Zeyber Zeyber marked this pull request as ready for review April 30, 2024 11:33
@github-actions github-actions bot marked this pull request as draft April 30, 2024 11:42
@Zeyber Zeyber marked this pull request as ready for review April 30, 2024 11:44
@cypress Cypress
Copy link

cypress bot commented Apr 30, 2024 •
edited
Loading

3 flaky tests on run #43685 ↗︎

0 119 2 0 Flakiness 3

Details:

Merge 908e64b into e7011ef...
Project: spartacus Commit: d3c34b7095 ℹ️
Status: Passed Duration: 04:13 💡
Started: May 16, 2024 8:27 AM Ended: May 16, 2024 8:31 AM
Flakiness  cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Test Replay Screenshots Video
SSR > should render PLP Test Replay Screenshots Video
SSR > should render PDP Test Replay Screenshots Video

Review all test suite changes for PR #18779 ↗︎

pawelfras
pawelfras reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@pawelfras pawelfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding README.md to the ssr-tests project with a short description what is the reason for having this package and how to run tests? It might be useful for folks who are new in the SSR area of SPA.

ci-scripts/unit-tests.sh Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft May 6, 2024 11:27
@Zeyber Zeyber marked this pull request as ready for review May 7, 2024 08:25
@github-actions github-actions bot marked this pull request as draft May 7, 2024 08:25
@Zeyber Zeyber marked this pull request as ready for review May 7, 2024 08:30
pawelfras
pawelfras reviewed May 8, 2024
View reviewed changes
projects/ssr-tests/README.md Outdated Show resolved Hide resolved
projects/ssr-tests/README.md Outdated Show resolved Hide resolved
projects/ssr-tests/README.md Outdated Show resolved Hide resolved
projects/ssr-tests/README.md Outdated Show resolved Hide resolved
projects/ssr-tests/README.md Outdated Show resolved Hide resolved
Zeyber and others added 2 commits May 10, 2024 10:06
@github-actions github-actions bot marked this pull request as draft May 10, 2024 08:06
@Zeyber Zeyber marked this pull request as ready for review May 15, 2024 13:52
@github-actions github-actions bot marked this pull request as draft May 15, 2024 13:52
@Zeyber Zeyber marked this pull request as ready for review May 15, 2024 13:53
@github-actions github-actions bot marked this pull request as draft May 15, 2024 13:53
@pawelfras pawelfras marked this pull request as ready for review May 16, 2024 06:49
pawelfras
pawelfras approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@pawelfras pawelfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥
Let's consider adding tests for introduced utils, in the separate task/PR.

@github-actions github-actions bot marked this pull request as draft May 16, 2024 08:17
@Zeyber Zeyber marked this pull request as ready for review May 16, 2024 08:18
@Zeyber Zeyber merged commit f1125b0 into develop May 16, 2024
26 checks passed
@Zeyber Zeyber deleted the feature/CXSPA-6525 branch May 16, 2024 08:54
@Zeyber
Copy link
Contributor Author

Zeyber commented May 16, 2024

QA Steps:

  1. Run npm install && npm run build:libs && npm run build && npm run build:ssr && npm run test:ssr
  2. See that the tests run (1 test should pass and 2 fail, this is expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelfras pawelfras pawelfras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeyber @pawelfras