Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop -> develop-next-major diff #19675

Merged
merged 27 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ca5e89d
fix: disable attribute key restriction for opf (#19660)
FollowTheFlo Dec 1, 2024
20683ab
fix: do not call `deleteUserAddress` for unlogged users (#19649)
Matejk00 Dec 2, 2024
5d66fa2
fix: Remove unnecessary visible text for screen-readers (#19672)
steinsebastian Dec 2, 2024
ec4a940
fix: Improve accessibility for OPF payments (#19610)
rmch91 Dec 2, 2024
a4b72ab
Added catch block to handle error scenarios. (#19676)
tiwariakshay55 Dec 2, 2024
66aaa74
fix: Support increased letter-spacing for header (#19682)
sdrozdsap Dec 3, 2024
287bc44
feat: (CXSPA-8988) - Add missing labels for Combo boxes in Order Summ…
petarmarkov9449 Dec 3, 2024
afb32e1
fix: Add required asterisks for permission form (#19681)
sdrozdsap Dec 3, 2024
0bba564
fix: remove v2 prefix from the endpoint
Matejk00 Dec 3, 2024
73c41a4
fix: add active language code to requests
Matejk00 Dec 3, 2024
20ab001
fix: four OPF fixes (#19661)
FollowTheFlo Dec 3, 2024
bb7b6af
fix: (CXSPA-9060) - Limit popover width on sub 375px devices (#19683)
Pio-Bar Dec 3, 2024
72bb771
fix: (CXSPA-9035) StoreFinder Truncation on applying text spacing set…
StanislavSukhanov Dec 3, 2024
89a4b7b
fix: (CXSPA-9086) ACC 271.1 (Level A): Product Configuration _ Tab _ …
Larisa-Staroverova Dec 4, 2024
e4f2aec
fix: make form required fields * label red (#19679)
uroslates Dec 4, 2024
a2c7711
fix: Tertiary buttons visible focus overlap (#19701)
Pio-Bar Dec 4, 2024
133fe3b
feat: (CXSPA-9022) - Fix one of the sides of the focus is placed out …
petarmarkov9449 Dec 4, 2024
a94c8c8
fix: (CXSPA-9026) make cx-banner focus visible for all 4 sides (#19704)
uroslates Dec 4, 2024
ce1a0f6
fix: elevate scroll to top button when overlaps with banner (#19711)
sdrozdsap Dec 5, 2024
eeb6c7f
fix: (CXSPA-9038) add label to store finder search input (#19692)
uroslates Dec 5, 2024
870b6a2
test: fix failing consignment-tracking e2e test (#19721)
sdrozdsap Dec 5, 2024
71738bc
fix: (CXSPA-9073) Fix tooltip for image attributes (#19709)
steinsebastian Dec 5, 2024
eb941e6
CXCDS-13427 Fixed failing cds e2e test (#19718)
klucerofermin Dec 5, 2024
d5809c0
feat: (CXSPA-9024) - Fix the issue where the focus only covers three …
petarmarkov9449 Dec 6, 2024
ebcd0f5
CXSPA-9102: export captchaService (#19725)
scarai-sap Dec 6, 2024
790fe55
fix: resolved the issue of infinite loading in SmartEdit when accessi…
kpawelczak Dec 6, 2024
6e538c5
fix: (CXSPA-9071) - Add aria-label for the buttons in ProductImageZoo…
petarmarkov9449 Dec 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
<!-- TODO: (CXSPA-5953) Remove feature flags next major -->
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
></span
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<abbr
*cxFeature="'a11yRequiredAsterisks'"
aria-hidden="true"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"recurrencePeriodType_MONTHLY": "Month",
"dayOfMonth": "On day",
"startOn": "Start on",
"repeatOnDays": "Repeat on the following days"
"repeatOnDays": "Repeat on the following days",
"duration": "Duration"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,20 @@
>
<div class="cx-replenishment-form-data-container">
<div *ngIf="!isMonthly" class="cx-days">
<span class="form-data-label">{{
'checkoutScheduledReplenishment.every' | cxTranslate
}}</span>
<span
class="form-data-label"
*cxFeature="'!a11yScheduleReplenishment'"
>{{ 'checkoutScheduledReplenishment.every' | cxTranslate }}</span
>
<label
class="form-data-label"
*cxFeature="'a11yScheduleReplenishment'"
for="order-replenishment-period-type"
>{{ 'checkoutScheduledReplenishment.every' | cxTranslate }}</label
>
<ng-container *ngIf="isWeekly; else isDaily">
<select
id="order-replenishment-period-type"
class="form-control"
(change)="changeNumberOfWeeks($event.target.value)"
>
Expand All @@ -71,6 +80,7 @@
</ng-container>
<ng-template #isDaily>
<select
id="order-replenishment-period-type"
class="form-control"
(change)="changeNumberOfDays($event.target.value)"
>
Expand All @@ -85,10 +95,29 @@
</ng-template>
</div>
<div class="cx-month">
<span *ngIf="isMonthly" class="form-data-label">{{
'checkoutScheduledReplenishment.every' | cxTranslate
}}</span>
<ng-container *cxFeature="'!a11yScheduleReplenishment'">
<span *ngIf="isMonthly" class="form-data-label">{{
'checkoutScheduledReplenishment.every' | cxTranslate
}}</span>
</ng-container>
<ng-container *cxFeature="'a11yScheduleReplenishment'">
<label
*ngIf="isMonthly"
class="form-data-label"
for="order-replenishment-recurrence-period"
>{{ 'checkoutScheduledReplenishment.every' | cxTranslate }}</label
>
<label
*ngIf="!isMonthly"
class="form-data-label"
for="order-replenishment-recurrence-period"
>{{
'checkoutScheduledReplenishment.duration' | cxTranslate
}}</label
>
</ng-container>
<select
id="order-replenishment-recurrence-period"
class="form-control"
(change)="changeRecurrencePeriodType($event.target.value)"
>
Expand All @@ -105,11 +134,22 @@
</select>
</div>
<div *ngIf="isMonthly" class="cx-dayMonth">
<span class="form-data-label">{{
'checkoutScheduledReplenishment.dayOfMonth' | cxTranslate
}}</span>
<span
class="form-data-label"
*cxFeature="'!a11yScheduleReplenishment'"
>{{ 'checkoutScheduledReplenishment.dayOfMonth' | cxTranslate }}</span
>
<label
class="form-data-label"
*cxFeature="'a11yScheduleReplenishment'"
for="order-replenishment-day-of-month"
>{{
'checkoutScheduledReplenishment.dayOfMonth' | cxTranslate
}}</label
>
<div class="cx-day-of-month">
<select
id="order-replenishment-day-of-month"
class="form-control"
(change)="changeDayOfTheMonth($event.target.value)"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import { Directive, ElementRef, HostListener } from '@angular/core';
import { FormControl, FormGroup, Validators } from '@angular/forms';
import { RoutingService } from '@spartacus/core';
import { RoutingService, useFeatureStyles } from '@spartacus/core';
import {
CustomerTicketingConfig,
CustomerTicketingFacade,
Expand Down Expand Up @@ -93,7 +93,9 @@ export abstract class CustomerTicketingDialogComponent {
protected filesFormValidators: FilesFormValidators,
protected customerTicketingFacade: CustomerTicketingFacade,
protected routingService: RoutingService
) {}
) {
useFeatureStyles('a11yExpandedFocusIndicator');
}

protected buildForm(): void {
const form = new FormGroup({});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ <h3>{{ 'checkoutOrderConfirmation.createAccount' | cxTranslate }}</h3>
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@
*ngIf="(types$ | async)?.length"
[formGroup]="$any(form.get('orderApprovalPermissionType'))"
>
<span class="label-content required">{{
'orgPurchaseLimit.orderApprovalPermissionType' | cxTranslate
}}</span>
<span class="label-content required">
{{ 'orgPurchaseLimit.orderApprovalPermissionType' | cxTranslate }}
<ng-template [ngTemplateOutlet]="requiredAsterisk"></ng-template>
</span>
<ng-select
[inputAttrs]="{ required: 'true' }"
formControlName="code"
Expand Down Expand Up @@ -68,9 +69,10 @@
</label>

<label *ngIf="form.get('periodRange')">
<span class="label-content required">{{
'orgPurchaseLimit.periodRange' | cxTranslate
}}</span>
<span class="label-content required">
{{ 'orgPurchaseLimit.periodRange' | cxTranslate }}
<ng-template [ngTemplateOutlet]="requiredAsterisk"></ng-template>
</span>
<ng-select
[inputAttrs]="{ required: 'true' }"
formControlName="periodRange"
Expand Down Expand Up @@ -101,9 +103,10 @@
*ngIf="form.get('currency')"
[formGroup]="$any(form.get('currency'))"
>
<span class="label-content required">{{
'orgPurchaseLimit.currency' | cxTranslate
}}</span>
<span class="label-content required">
{{ 'orgPurchaseLimit.currency' | cxTranslate }}
<ng-template [ngTemplateOutlet]="requiredAsterisk"></ng-template>
</span>
<ng-select
*ngIf="currencies$ | async as currencies"
[inputAttrs]="{ required: 'true' }"
Expand Down Expand Up @@ -133,9 +136,10 @@
</label>

<label *ngIf="form.get('threshold')">
<span class="label-content required">{{
'orgPurchaseLimit.threshold' | cxTranslate
}}</span>
<span class="label-content required">
{{ 'orgPurchaseLimit.threshold' | cxTranslate }}
<ng-template [ngTemplateOutlet]="requiredAsterisk"></ng-template>
</span>
<input
class="form-control"
type="number"
Expand Down Expand Up @@ -198,7 +202,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@
<ng-template #requiredAsterisk>
<abbr
*cxFeature="'a11yRequiredAsterisks'"
class="text-decoration-none"
class="text-decoration-none required-asterisk"
aria-hidden="true"
title="{{ 'common.required' | cxTranslate }}"
>*</abbr
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@
"filterOverviewByGroup": "Filter configuration overview by group {{groupName}}",
"closeConflictSolverModal": "Close conflict solver modal",
"closeRestartDialog": "Close the \"Unfinished Configuration\" dialog and navigate back to the product details page",
"description": "Click to see a description for this value"
"description": "Click to see a description for value {{ value }}"
},
"variantCarousel": {
"title": "Pre-configured Versions"
Expand Down
Loading
Loading