(closed in favor of #19799) feat: allow for tree-shaking unused langauges translations in custom apps #19795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, and generating chunks config and validating names of chunk files
spartacus-serviceuser
had a problem deploying
to
dev
GitHub Actions
Failure
…ns.ts export each language separately. Moreover, deprecate the old "feature-prefixed" const with chunks config. and deprecate old "feature-prefixed" const with wrapper `translations` object
Platonn
force-pushed
the
epic/tew-translation--script-updating-ts-files
branch
from
cb02806 to
901063d
Compare
spartacus-serviceuser
had a problem deploying
to
dev
GitHub Actions
Failure
Platonn
changed the title
Platonn
changed the title
Platonn
changed the title
|
closing in favor of #19799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index.tsfiles to re-export translations in TS for new langaugestranslations.tsbarrel files, to export each langauge in a separate public API members (to allow for treeshaking unused langauges)<featureName>Translationsthe languages other thanen(which were added only in the branch epic/tew-translation before)<featureName>Translations(and<featureName>TranslationsChunksConfig) in favor of favour the new non-prefixed conststranslationsEn,translationsDe,... for specific langauges (and non-prefixedtranslationChunksConfig).By the way:
translation.tsfiles andindex.tsfiles. That said, the translation chunks configs were brought back manually laterTODO:
related to https://jira.tools.sap/browse/CXSPA-9131
OTHER STEPS not included in this PR:
{ en: translationsEn }