fix: (CXSPA-9005) fix ng-select options issue - <y of x> is conveyed twice #19844
Conversation
Merge Checks Failed |
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9005
|
| Run status |
|
| Run duration | 04m 07s |
| Commit |
|
| Committer | Uros Lates |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
projects/storefrontlib/shared/components/ng-select-a11y/ng-select-a11y.directive.ts
Show resolved
Hide resolved
| } | ||
| ); | ||
| }); | ||
| options.forEach((option: HTMLOptionElement) => { |
There was a problem hiding this comment.
I think we need a feature toggle here.
There was a problem hiding this comment.
Thanks Stan for the heads up & catching this one!
I've reiterated over with Caine and code is updated now.
|
Changed the implementation - setting a11yNgSelectOptionsCount to false (per default) will cause ng-select options ariaLabels to working as expected. Marked all relevant directive methods as depricated. Hopefully the depricated code (including the flag) would be removed in next major release (undoing part of old directive which is now introducing issue) - making everything work normal. |
| a11yNgSelectOptionsCount: true, | ||
| /** | ||
| * Defaults to false cause ng-select options ariaLabels are working as expected | ||
| * since Spartacus 2211.33 |
There was a problem hiding this comment.
Lets also reference the issue CX-9005 here and in feature-toggles.ts so anybody curious can reference the discussion about this flag.
There was a problem hiding this comment.
Updated comment with reference to the related issue.
Closes https://jira.tools.sap/browse/CXSPA-9005