Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CXSPA-9009) - Fix convey input field errors on repeat navigation #19852

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

petarmarkov9449
Copy link
Contributor

@petarmarkov9449 petarmarkov9449 commented Jan 10, 2025

Closes: CXSPA-9009

Fix convey input field errors on repeat navigation.

@petarmarkov9449 petarmarkov9449 requested review from a team as code owners January 10, 2025 11:36
@github-actions github-actions bot marked this pull request as draft January 10, 2025 11:37
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 10, 2025 11:57
Copy link

cypress bot commented Jan 10, 2025

spartacus    Run #46673

Run Properties:  status check passed Passed #46673  •  git commit 6f591c68c3 ℹ️: Merge a79c18fc797c0290dc785ab1ff9fd3e66b475e5b into e7b7e653ec7e07b35787b6402c39...
Project spartacus
Branch Review feature/CXSPA-9009
Run status status check passed Passed #46673
Run duration 04m 35s
Commit git commit 6f591c68c3 ℹ️: Merge a79c18fc797c0290dc785ab1ff9fd3e66b475e5b into e7b7e653ec7e07b35787b6402c39...
Committer petarmarkov9449
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

sdrozdsap
sdrozdsap previously approved these changes Jan 14, 2025
Copy link
Contributor

@Zeyber Zeyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see empty files [email protected] and env-cmd made it into here.

@github-actions github-actions bot marked this pull request as draft January 15, 2025 06:04
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 15, 2025 06:22
@github-actions github-actions bot marked this pull request as draft January 16, 2025 07:37
@petarmarkov9449 petarmarkov9449 marked this pull request as ready for review January 16, 2025 08:07
@petarmarkov9449 petarmarkov9449 merged commit 22476ef into develop Jan 16, 2025
28 checks passed
@petarmarkov9449 petarmarkov9449 deleted the feature/CXSPA-9009 branch January 16, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants