chore: add migration scripts for bootstrap dependency removal #19926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/CXSPA-9283
Platonn
reviewed
Jan 30, 2025
Comment on lines
28
to
44
| export function uninstallBootstrap(): Rule { | ||
| return (tree: Tree, context: SchematicContext) => { | ||
| // Execute the npm uninstall command | ||
| exec('npm uninstall bootstrap', (error, stdout, stderr) => { | ||
| if (error) { | ||
| context.logger.error(`Error uninstalling Bootstrap: ${error.message}`); | ||
| return; | ||
| } | ||
| if (stderr) { | ||
| context.logger.warn(`Warnings during uninstall: ${stderr}`); | ||
| } | ||
| context.logger.info(`Bootstrap uninstalled successfully:\n${stdout}`); | ||
| }); | ||
|
|
||
| return tree; | ||
| }; | ||
| } |
There was a problem hiding this comment.
[MEDIUM]
- Some customers might be using yarn or pnpm. So we should not execute the
npmcommand directly, but instead rely on some more universal mechanisms for dependency management. - Don't we already have a logic for removing Bootstrap in this file:
.../2212_32/dependency-management/dependency-management.ts?
There was a problem hiding this comment.
I've tried using dependecy-management but it doesnt remove bootstrap and as far as I remember, the code I think doesnt have any functions that would remove bootstrap. All it does is show a message about bootstrap.
There was a problem hiding this comment.
After second look it does filter out the libraries from the package json and runs installation. However, in my testing it never removed bootstrap.
There was a problem hiding this comment.
I can confirm that the dependency manager is aimed only at spartacus libraries
projects/schematics/src/migrations/2212_32/bootstrap/bootstrap.ts
Outdated
Show resolved
Hide resolved
projects/schematics/src/migrations/2212_32/bootstrap/replace-bootstrap-imports.ts
Outdated
Show resolved
Hide resolved
projects/schematics/src/migrations/2212_32/bootstrap/replace-bootstrap-imports.ts
Outdated
Show resolved
Hide resolved
projects/schematics/src/migrations/2212_32/bootstrap/add-imports-in-libraries.ts
Outdated
Show resolved
Hide resolved
…ootstrap-imports.ts Co-authored-by: Krzysztof Platis <[email protected]>
…ootstrap-imports.ts Co-authored-by: Krzysztof Platis <[email protected]>
Co-authored-by: Krzysztof Platis <[email protected]>
Co-authored-by: Krzysztof Platis <[email protected]>
…into feature/CXSPA-9283
…into feature/CXSPA-9283
Merge Checks Failed |
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9283
|
| Run status |
|
| Run duration | 12m 00s |
| Commit |
|
| Committer | kpawelczak |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Platonn
previously approved these changes
Feb 3, 2025
Platonn
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: CXSPA-9283
The
migration.jsonfile will likely need to be updated. Currently, the changes made are only intended to enable testing.QA (installation script):
npm run config:updateand thennpm run generate:depsts-node ./tools/schematics/testing.tsin the SPA root folderng add @spartacus/schematics, e.g. from RBSC (.npmrc is needed)ng update @spartacus/schematics