Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add option to redefine output directory structure #665

Merged
merged 12 commits into from
Dec 12, 2023

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented Nov 29, 2023

New CLI build option --output-style. Whether to omit the /resources/<namespace> directory structure in the build output.

Resolves SAP/ui5-tooling#507
Depends on: SAP/ui5-project#624

@coveralls
Copy link

coveralls commented Nov 29, 2023

Coverage Status

coverage: 96.63% (-0.1%) from 96.726%
when pulling eb45644 on flat-build-output
into fb1fdde on main.

@d3xter666 d3xter666 requested a review from a team December 1, 2023 08:59
@d3xter666 d3xter666 changed the title [FEATURE] Add option to request flat build output [FEATURE] Add option to redefine output directory structure Dec 5, 2023
lib/cli/commands/build.js Outdated Show resolved Hide resolved
"\"Flat\" omits the project namespace and the \"resources\" directory. This is" +
" currently only supported for projects of type 'library'. Projects of " +
"type 'application' always result in a flat output." +
"No other dependencies can be included in the build result.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other dependencies can be included now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how deep into details should we go here. Hopefully, now is ok

test/lib/cli/commands/build.js Show resolved Hide resolved
@RandomByte RandomByte requested a review from KlattG December 12, 2023 10:00
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 requested a review from RandomByte December 12, 2023 12:08
@d3xter666 d3xter666 merged commit 388dc79 into main Dec 12, 2023
15 checks passed
@d3xter666 d3xter666 deleted the flat-build-output branch December 12, 2023 13:17
d3xter666 added a commit to SAP/ui5-tooling that referenced this pull request Dec 14, 2023
Adds a section which describes the Build Output Styles feature and usage
variants.

Depends on:
- SAP/ui5-project#624
- SAP/ui5-cli#665

---------

Co-authored-by: Günter Klatt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for flat build output of the root (library-)project
5 participants