Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Refactor tests to get rid of chai and chai-fs #549

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Feb 21, 2024

chai-fs is not compatible with latest version of chai. Therefore its easier to get rid of chai completely.

JIRA: CPOUI5FOUNDATION-801

@flovogt flovogt requested review from a team and RandomByte February 21, 2024 15:17
@coveralls
Copy link

coveralls commented Feb 21, 2024

Coverage Status

coverage: 90.283%. remained the same
when pulling bf6cbf3 on remove-chai
into 465638d on main.

@flovogt flovogt force-pushed the remove-chai branch 2 times, most recently from 84c629b to 2147a5c Compare February 21, 2024 18:44
test/lib/adapters/FileSystem_write.js Outdated Show resolved Hide resolved
test/lib/adapters/FileSystem_write.js Outdated Show resolved Hide resolved
@flovogt flovogt merged commit 5fb0219 into main Feb 23, 2024
17 checks passed
@flovogt flovogt deleted the remove-chai branch February 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants