Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Fix release note generation for v4 #579

Closed
wants to merge 1 commit into from

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Jul 18, 2024

git-chglog --sort semver -c .chglog/release-config.yml --next-tag HEAD HEAD generates the changelog for the next release as expected with this change

git-chglog --sort semver -c .chglog/release-config.yml v4.0.0 generates the changelog for the given release tag as expected.

Using the tag_filter_pattern option leads to more commits added to the changelog which are already released with older releases.

`git-chglog --sort semver -c .chglog/release-config.yml --next-tag HEAD HEAD` generates the changelog for the next release as expected with this change

`git-chglog --sort semver -c .chglog/release-config.yml v4.0.0` generates the changelog for the given release tag as expected.

Using the `tag_filter_pattern` option leads to more commits added to the changelog which are already released with older releases.
@flovogt flovogt force-pushed the fix-release-note-generation-for-v4 branch from 613e5dc to 858bfa1 Compare July 18, 2024 14:14
@coveralls
Copy link

coveralls commented Jul 18, 2024

Coverage Status

coverage: 90.231%. remained the same
when pulling 858bfa1 on fix-release-note-generation-for-v4
into 05032cf on main.

@flovogt flovogt changed the title fix release note generation for v4 [INTERNAL] Fix release note generation for v4 Jul 18, 2024
@flovogt flovogt requested a review from a team July 18, 2024 14:28
@RandomByte
Copy link
Member

Let's check on this together. I can't reproduce the issue this is trying to fix

@flovogt
Copy link
Member Author

flovogt commented Jul 23, 2024

Agreed on a different process. Therefore, closing.

@flovogt flovogt closed this Jul 23, 2024
@flovogt flovogt deleted the fix-release-note-generation-for-v4 branch July 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants