🐛 Allow passing extra_libs to CheckLibWithHeader

[rdbisme]

Contributor Checklist:

• I have created a new test or updated the unit tests to cover the new/changed functionality.
• I have updated CHANGES.txt and RELEASE.txt (and read the README.rst).
• I have updated the appropriate documentation

[mwichmann]

The concept seems good... not sure why that argument was left out of the upper layer when it's present in the lower layer (Conftest.py). Could ask the same question about SConf/CheckLib.

[rdbisme]

First time I contribute to scons. Do I need to add a specific test for this?

[bdbaddog]

First time I contribute to scons. Do I need to add a specific test for this?

Yes. That's why we have the checklist in the initial decription.
You can edit it and add an X next to each item once you've added it.

[bdbaddog]

And add this change to the docs as well.
We'll help you through those if you need help.
Also asking on the discord server may be useful.

[rdbisme]

Yes. That's why we have the checklist in the initial decription.
You can edit it and add an X next to each item once you've added it.

I mean, my remark was more like that test wouldn't test much? CheckLib already has that argument. I'm just exposing it in the interface of CheckLibWithHeadere, but I'll give a look to the tests. :)

[rdbisme]

I should have added all things required. I'm not 100% sure about the doc (XML, really?! :)).

[mwichmann]

Yes, xml, really :-) (this project dates back just a few years, like 20+). We can help with docs, there's not really much to do there for this kind of change.

The configure stuff is a weird two-layer thing, SConf is the "API layer" and Conftest is the implementation layer. Except, they reach into each other and aren't as separated as they could be. Not making excuses.

[bdbaddog]

@mwichmann - what's the blurb to indicate this is added in NEXT_RELEASE?