Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks can (and should) now be defined as extensions of other tasks. #3530

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

prescod
Copy link
Contributor

@prescod prescod commented Feb 9, 2023

A custom task can now be defined like this:

deploy_reports:
    description: Deploy Reports
    extends: deploy
    group: My Project
    options:
        path: unpackaged/config/reports

Instead of like this:

deploy_reports:
    description: Deploy Reports
    class_path: cumulusci.tasks.salesforce.Deploy
    group: My Project
    options:
        path: unpackaged/config/reports

This means that the classpath of CCI tasks can be treated as an implementation detail rather than part of the YAML syntax.

@prescod prescod requested a review from a team as a code owner February 9, 2023 21:47
@@ -39,7 +39,6 @@ tasks:
- RequireTestDocumentation
robot_libdoc:
description: Generates html documentation for the Salesorce and CumulusCI libraries and resource files
class_path: cumulusci.tasks.robotframework.RobotLibDoc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was always redundant because "the merge" provides it.

@salesforce-cla
Copy link

Thanks for the contribution! It looks like @prescod is an internal user so signing the CLA is not required. However, we need to confirm this.

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Paul Prescod <p***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants