Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated user query to select Active Standard users #2845

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

updated user query to select Active Standard users #2845

wants to merge 3 commits into from

Conversation

timbarton1966
Copy link
Contributor

Updated packaging org user report query to only select UserType=Standard users.
This will make the packaging org report reflect the same user list as in the UI for a packaging org.

@timbarton1966 timbarton1966 marked this pull request as ready for review September 11, 2024 16:22
@timbarton1966 timbarton1966 requested a review from a team as a code owner September 11, 2024 16:22
nchitre-sf
nchitre-sf previously approved these changes Sep 23, 2024
View reviewed changes
@nchitre-sf
Copy link
Contributor

@timbarton1966

  • Is this a new change or has this been done in the past ?
  • when does it need to be rolled out?

jstvz
jstvz previously approved these changes Sep 26, 2024
View reviewed changes
@nchitre-sf
Copy link
Contributor

@timbarton1966 - can you please check the query and fix the error ?

jstvz
jstvz reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are a little weird. You'll need to update this line to match the new query:

MetaCI/metaci/users/management/commands/tests/test_packaging_org_users.py

Line 28 in 55b53b1

== "SELECT Name, Email, UserType, IsActive, Profile.Name, Title from User WHERE IsActive=True"

@timbarton1966 timbarton1966 dismissed stale reviews from jstvz and nchitre-sf via 44470ef November 19, 2024 15:25
@nchitre-sf nchitre-sf self-requested a review November 20, 2024 20:43
nchitre-sf
nchitre-sf approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@nchitre-sf nchitre-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and unit tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchitre-sf nchitre-sf nchitre-sf approved these changes

@jstvz jstvz jstvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timbarton1966 @nchitre-sf @jstvz